Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[Kibana] Closes #1574 Fix readinessProbe double brace notation error #1575

Closed
wants to merge 1 commit into from

Conversation

Gaian-pixel
Copy link

The error was caused by an incorrect double brace notation inside the last readinessProbe condition, causing the condition to never be true
Fixed by removing a couple of braces.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

1 similar comment
@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Feb 15, 2022

💚 CLA has been signed

@Gaian-pixel
Copy link
Author

x Author of the following commits did not sign a Contributor Agreement: f5bdae6

Please, read and sign the above mentioned agreement if you want to contribute to this project

signed

@Gaian-pixel Gaian-pixel closed this Mar 2, 2022
@Gaian-pixel Gaian-pixel reopened this Mar 2, 2022
@jmlrt
Copy link
Member

jmlrt commented Mar 2, 2022

Hi @Gaian-pixel, the double bracket is the correct syntax in bash. Can you provide more details about the error you are trying to fix?

@jmlrt jmlrt added the kibana label Mar 2, 2022
@Gaian-pixel
Copy link
Author

Gaian-pixel commented Mar 2, 2022

Hi @Gaian-pixel, the double bracket is the correct syntax in bash. Can you provide more details about the error you are trying to fix?

But it is actually using sh

Here is where it is declared

{{ toYaml .Values.readinessProbe | indent 10 }}
          exec:
            command:
              - sh
              - -c 

@jmlrt
Copy link
Member

jmlrt commented Mar 2, 2022

Yes, it was using sh in the previous versions but it has already been fixed in #1530 by changing the shell to bash.

@Gaian-pixel
Copy link
Author

Yes, it was using sh in the previous versions but it has already been fixed in #1530 by changing the shell to bash.

OK I was not aware of the fix.
Thanks for the reply.

@Gaian-pixel Gaian-pixel closed this Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants