Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[kibana] Add configurable nodePort to service spec #160

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Conversation

Crazybus
Copy link
Contributor

@Crazybus Crazybus commented Jun 12, 2019

Fixes: #139

  • Chart version not bumped (the versions are all bumped and released at the same time)
  • README.md updated with any new values or changes
  • Updated template tests in ${CHART}/tests/*.py
  • Updated integration tests in ${CHART}/examples/*/test/goss.yaml

Looking at the last build failure it seems like the curl --retry option
doesn't retry for all kinds of failures. Adding the retry with the sleep
will hopefully make this not flake occasionally.
@Crazybus Crazybus requested a review from tylerjl June 12, 2019 15:18
Copy link
Contributor

@tylerjl tylerjl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Crazybus Crazybus merged commit e71376c into master Jun 13, 2019
@Crazybus Crazybus deleted the no_node_port branch June 13, 2019 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow configuring a NodePort
2 participants