This repository has been archived by the owner on May 16, 2023. It is now read-only.
kibana: fixed bogus request of 500 millibytes mem #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
accek
changed the title
Crazybus
approved these changes
Sep 18, 2019
There was a problem hiding this comment.
LGTM!
Nice catch! Do you know if 500m is also invalid? My best bet is that the regex matched correctly because it is a valid way for CPU to be specified:
error: deployments.extensions "ea-kibana-kibana" could not be patched: quantities must match the regular expression '^([+-]?[0-9.]+)([eEinumkKMGTP]*[-+]?[0-9]*)$'
|
jenkins test this please |
|
jenkins test this please |
500m is theoretically valid for memory, but useless. It is accepted by k8s and means 0.5 bytes (half a byte). |
|
Thanks for clarifying! Now it makes sense why it never got caught. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml