This repository has been archived by the owner on May 16, 2023. It is now read-only.
[logstash] remove expected logstash host and name assertion #724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fix expected logstash host and name in Logstash tests with 6.x. When using a headless service (4a6067e), Logstash 6.x use the full name of the service.
|
jenkins test this please |
1 similar comment
|
jenkins test this please |
jmlrt
changed the title
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit remove expected Logstash host and name in Logstash tests with 6.x.
When using a headless service (4a6067e), Logstash 6.x use the full name of the service related to the namespace (ie:
helm-logstash-default-logstash-0.helm-logstash-oss-logstash-headless.helm-charts-testing.svc.cluster.local). Keeping this test would require a hard coupling between the test and the namespace where it is running.