This repository has been archived by the owner on May 16, 2023. It is now read-only.
[meta] stabilize CI tests #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit watch resources rollout after upgrade to ensure that goss tests are run on "upgraded" pods.
This commit standardizes the examples to simplify their maintenance: - use variable for timeout values - use `.yaml` extension for every test value files - rename security examples yaml files for consistency with other examples values files - reorder and standardize make targets to simplify diff - remove unused or obsolete make targets
jmlrt
force-pushed
the
upgrade-rollout
branch
from
4e42928
to
2893264
Compare
|
jenkins test this please |
1 similar comment
|
jenkins test this please |
This commit update goss `kubectl get pod` command to retrieve only running pods and sort them by age, then use the newer pod for goss test. This is required to ensure that we aren't running goss tests on an older pod which is terminating.
This commit remove the hostname checks into goss tests to avoid error when goss tests aren't run on the first pod.
|
CI test is 🟢 again 🎉 |
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Nov 25, 2020
This PR add some improvements to stabilize CI tests which are flaking at this time: - watch resources rollout after upgrade to ensure that goss tests when rollout is done - use newest running pod for goss tests to ensure that it is not using a pod from previous release or a pod which is terminating - remove mention of hostname in goss tests to ensure that test can run in every pods of the Statefulsets, DaemonSets or Deployments - increase some more timeouts for Elasticsearch tests - standardize examples to simplify maintenance and diff
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Nov 25, 2020
This PR add some improvements to stabilize CI tests which are flaking at this time: - watch resources rollout after upgrade to ensure that goss tests when rollout is done - use newest running pod for goss tests to ensure that it is not using a pod from previous release or a pod which is terminating - remove mention of hostname in goss tests to ensure that test can run in every pods of the Statefulsets, DaemonSets or Deployments - increase some more timeouts for Elasticsearch tests - standardize examples to simplify maintenance and diff
jmlrt
added a commit
to jmlrt/helm-charts
that referenced
this pull request
Nov 25, 2020
This PR add some improvements to stabilize CI tests which are flaking at this time: - watch resources rollout after upgrade to ensure that goss tests when rollout is done - use newest running pod for goss tests to ensure that it is not using a pod from previous release or a pod which is terminating - remove mention of hostname in goss tests to ensure that test can run in every pods of the Statefulsets, DaemonSets or Deployments - increase some more timeouts for Elasticsearch tests - standardize examples to simplify maintenance and diff
jmlrt
added a commit
that referenced
this pull request
Nov 25, 2020
This PR add some improvements to stabilize CI tests which are flaking at this time: - watch resources rollout after upgrade to ensure that goss tests when rollout is done - use newest running pod for goss tests to ensure that it is not using a pod from previous release or a pod which is terminating - remove mention of hostname in goss tests to ensure that test can run in every pods of the Statefulsets, DaemonSets or Deployments - increase some more timeouts for Elasticsearch tests - standardize examples to simplify maintenance and diff
jmlrt
added a commit
that referenced
this pull request
Nov 25, 2020
This PR add some improvements to stabilize CI tests which are flaking at this time: - watch resources rollout after upgrade to ensure that goss tests when rollout is done - use newest running pod for goss tests to ensure that it is not using a pod from previous release or a pod which is terminating - remove mention of hostname in goss tests to ensure that test can run in every pods of the Statefulsets, DaemonSets or Deployments - increase some more timeouts for Elasticsearch tests - standardize examples to simplify maintenance and diff
jmlrt
added a commit
that referenced
this pull request
Nov 25, 2020
This PR add some improvements to stabilize CI tests which are flaking at this time: - watch resources rollout after upgrade to ensure that goss tests when rollout is done - use newest running pod for goss tests to ensure that it is not using a pod from previous release or a pod which is terminating - remove mention of hostname in goss tests to ensure that test can run in every pods of the Statefulsets, DaemonSets or Deployments - increase some more timeouts for Elasticsearch tests - standardize examples to simplify maintenance and diff
Closed
This was referenced Feb 12, 2021
Merged
Closed
This was referenced Dec 14, 2021
Merged
Merged
Merged
This was referenced Sep 14, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add some improvements to stabilize CI tests which are flaking at this time: