-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update install-layout.asciidoc to reflect logging changes introduced in 8.6.0 #631
Conversation
Updated widget to reflect the logging changes from 8.6.0 (v2 architecture) to close this issue: #175 Related changes: elastic/elastic-agent#1701
This pull request does not have a backport label. Could you fix it @rseldner? 🙏
|
I think this should be backported as far as 8.6 but not seeing a label for that version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request is now in conflict. Could you fix it @rseldner? 🙏
|
Hi @kilfoyle this resulted in conflicts because it was not merged in time. I believe I resolved the conflicts. Can you take a look? |
Hi @rseldner. Looks good! I just applied my suggestions so that we use the |
…in 8.6.0 (#631) * Update install-layout.asciidoc Updated widget to reflect the logging changes from 8.6.0 (v2 architecture) to close this issue: #175 Related changes: elastic/elastic-agent#1701 * Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc * Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc * Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc * Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc * Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc --------- Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com> (cherry picked from commit 4fd3a33)
By the way, I should explain this a bit better:
We avoid pushing docs changes into releases that are no longer active because it can create an expectation that all changes are handled this way (and often we're unable to push changes into certain releases). Rather than create inconsistency, we try to stick to a policy of updating only the "active" branches. Just wanted to add some clarity about that. :-) |
…in 8.6.0 (#631) (#683) * Update install-layout.asciidoc Updated widget to reflect the logging changes from 8.6.0 (v2 architecture) to close this issue: #175 Related changes: elastic/elastic-agent#1701 * Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc * Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc * Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc * Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc * Update docs/en/ingest-management/tab-widgets/install-layout.asciidoc --------- Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com> (cherry picked from commit 4fd3a33) Co-authored-by: Roberto Seldner <rseldner@users.noreply.github.com>
Updated widget to reflect the logging changes introduced in 8.6.0 (v2 architecture) to close this issue: #175
elastic-agent-json.log
toelastic-agent.ndjson
elastic-agent.ndjson
rather than their own log file.I believe the logging changes were introduces in the v2 architecture:
elastic/elastic-agent#1701