Skip to content

Commit

Permalink
incorporate feedback
Browse files Browse the repository at this point in the history
- fix indentation in fields files
- fix "fail_on_error" option in dns
  • Loading branch information
leehinman committed Dec 10, 2020
1 parent ffd313c commit ffe02cb
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 12 deletions.
8 changes: 4 additions & 4 deletions packages/zeek/data_stream/dns/agent/stream/log.yml.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ processors:
target: zeek.dns
- registered_domain:
ignore_missing: true
ignore_failure: true
fail_on_error: false
field: zeek.dns.query
target_field: dns.question.registered_domain
- script:
Expand Down Expand Up @@ -157,7 +157,7 @@ processors:
}
- convert:
ignore_missing: true
ignore_failure: true
fail_on_error: false
mode: rename
fields:
- {from: zeek.dns.id.orig_h, to: source.address}
Expand All @@ -168,7 +168,7 @@ processors:
- {from: zeek.dns.proto, to: network.transport}
- convert:
ignore_missing: true
ignore_failure: true
fail_on_error: false
mode: copy
fields:
- {from: source.address, to: source.ip, type: ip}
Expand All @@ -180,7 +180,7 @@ processors:
- {from: zeek.dns.rcode_name, to: dns.response_code}
- convert:
ignore_missing: true
ignore_failure: true
fail_on_error: false
fields:
- {from: zeek.dns.trans_id, type: string}
- add_fields:
Expand Down
3 changes: 1 addition & 2 deletions packages/zeek/data_stream/dns/fields/ecs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,8 +79,7 @@
ignore_above: 1024
name: dns.answers.name
type: keyword
- description: The time interval in seconds that this resource record may be cached
before it should be discarded.
- description: The time interval in seconds that this resource record may be cached before it should be discarded.
example: 180
name: dns.answers.ttl
type: long
Expand Down
3 changes: 1 addition & 2 deletions packages/zeek/data_stream/ssl/fields/ecs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,7 @@
name: tls.server.x509.issuer.country
type: keyword
- description: Distinguished name (DN) of issuing certificate authority.
example: C=US, O=Example Inc, OU=www.example.com, CN=Example SHA2 High Assurance
Server CA
example: C=US, O=Example Inc, OU=www.example.com, CN=Example SHA2 High Assurance Server CA
ignore_above: 1024
name: tls.server.x509.issuer.distinguished_name
type: keyword
Expand Down
6 changes: 2 additions & 4 deletions packages/zeek/data_stream/x509/fields/ecs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@
name: file.x509.issuer.country
type: keyword
- description: Distinguished name (DN) of issuing certificate authority.
example: C=US, O=Example Inc, OU=www.example.com, CN=Example SHA2 High Assurance
Server CA
example: C=US, O=Example Inc, OU=www.example.com, CN=Example SHA2 High Assurance Server CA
ignore_above: 1024
name: file.x509.issuer.distinguished_name
type: keyword
Expand Down Expand Up @@ -82,8 +81,7 @@
ignore_above: 1024
name: file.x509.public_key_algorithm
type: keyword
- description: The curve used by the elliptic curve public key algorithm. This is
algorithm specific.
- description: The curve used by the elliptic curve public key algorithm. This is algorithm specific.
example: nistp521
ignore_above: 1024
name: file.x509.public_key_curve
Expand Down

0 comments on commit ffe02cb

Please sign in to comment.