Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fields yaml files typos #2643

Closed
1 of 15 tasks
efd6 opened this issue Feb 7, 2022 · 8 comments
Closed
1 of 15 tasks

fields yaml files typos #2643

efd6 opened this issue Feb 7, 2022 · 8 comments
Labels
good first issue Good for newcomers release-pending Stalled Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring] Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@efd6
Copy link
Contributor

efd6 commented Feb 7, 2022

While working on a package/ECS yaml file analyser I found a collection of field name typos in a variety of field description files:

  • default_fields (?) — packages/network_traffic/data_stream/tls/fields/protocol.yml
  • descriiption — packages/mimecast/data_stream/audit_events/fields/ecs.yml
  • descripion —
    • packages/elastic_agent/data_stream/apm_server_metrics/fields/beat-fields.yml
    • packages/elastic_agent/data_stream/auditbeat_metrics/fields/beat-fields.yml
    • packages/elastic_agent/data_stream/elastic_agent_metrics/fields/beat-fields.yml
    • packages/elastic_agent/data_stream/endpoint_security_metrics/fields/beat-fields.yml
    • packages/elastic_agent/data_stream/filebeat_metrics/fields/beat-fields.yml
    • packages/elastic_agent/data_stream/fleet_server_metrics/fields/beat-fields.yml
    • packages/elastic_agent/data_stream/heartbeat_metrics/fields/beat-fields.yml
    • packages/elastic_agent/data_stream/metricbeat_metrics/fields/beat-fields.yml
    • packages/elastic_agent/data_stream/osquerybeat_metrics/fields/beat-fields.yml
    • packages/elastic_agent/data_stream/packetbeat_metrics/fields/beat-fields.yml
  • dimensiont — packages/kubernetes/data_stream/state_replicaset/fields/base-fields.yml
  • dimensions (?) — packages/kubernetes/data_stream/state_statefulset/fields/base-fields.yml
@efd6 efd6 added Team:Security-External Integrations release-pending Team:Elastic-Agent Label for the Agent team Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring] labels Feb 7, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@jlind23 jlind23 added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Feb 7, 2022
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@jlind23 jlind23 added the good first issue Good for newcomers label Feb 7, 2022
@efd6 efd6 mentioned this issue Feb 8, 2022
4 tasks
@ruflin
Copy link
Member

ruflin commented Feb 21, 2022

@jsoriano @mtojek Is this something we could potentially catch during validation?

@jsoriano
Copy link
Member

Is this something we could potentially catch during validation?

I guess we could set additionalProperties: false in the fields spec, I have opened a PR for this: elastic/package-spec#281

Is there any reason to don't do this?

@ruflin
Copy link
Member

ruflin commented Feb 21, 2022

As long as the spec is fully up-to-date with which fields are allowed, it should be fine. It likely will mean as soon as the package-spec is updated, some packages will need adjustment but this is a good thing.

@jsoriano
Copy link
Member

I have created elastic/package-spec#282 to follow up on stricter validation of fields properties.

@botelastic
Copy link

botelastic bot commented Feb 21, 2023

Hi! We just realized that we haven't looked into this issue in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Feb 21, 2023
@botelastic botelastic bot closed this as completed Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers release-pending Stalled Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team [elastic/obs-cloudnative-monitoring] Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

No branches or pull requests

5 participants