-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
network_traffic: fix typo #2648
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
bug
Something isn't working, use only for issues
Team:Security-External Integrations
8.1-candidate
labels
Feb 8, 2022
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh
reviewed
Feb 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove default_field
(and default_fields
) entirely because it has no use within Fleet packages.
I'll do that for this package and follow up for others with an issue. |
andrewkroh
reviewed
Feb 8, 2022
andrewkroh
approved these changes
Feb 8, 2022
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
eyalkraft
pushed a commit
to build-security/integrations
that referenced
this pull request
Mar 30, 2022
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes a typo.
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
elastic-package test
in network_traffic.Related issues
Screenshots