Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitdefender: Update doc with input limitation collecting jsonRPC format. #10019

Merged
merged 2 commits into from
May 30, 2024

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented May 30, 2024

Proposed commit message

Update doc with input limitations.

The http_endpoint input limitation on jsonRPC format 
is not properly explained inside the doc, which is confusing to users. 
Update the doc explaining the input limitation on jsonRPC format.

Other changes:
  - Remove comments from pipeline definition.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

Before:
Screenshot 2024-05-30 at 12 36 18 PM

After:
Screenshot 2024-05-30 at 12 35 48 PM

@kcreddy kcreddy self-assigned this May 30, 2024
@kcreddy kcreddy added Integration:bitdefender BitDefender enhancement New feature or request labels May 30, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @kcreddy

Copy link

@kcreddy kcreddy marked this pull request as ready for review May 30, 2024 07:50
@kcreddy kcreddy requested a review from a team as a code owner May 30, 2024 07:50
@kcreddy kcreddy added the Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] label May 30, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing those comments.

Note that after 8.14, http_endpoint will be able to handle this kind of POST body since it will be able to evaluate a limited CEL program on the body.

@kcreddy kcreddy merged commit f5033a4 into elastic:main May 30, 2024
5 checks passed
@kcreddy
Copy link
Contributor Author

kcreddy commented May 30, 2024

Note that after 8.14, http_endpoint will be able to handle this kind of POST body since it will be able to evaluate a limited CEL program on the body.

Created #10020 to support this format.

@elasticmachine
Copy link

Package bitdefender - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=bitdefender

@kcreddy kcreddy deleted the bitdefender-cleanup branch February 7, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:bitdefender BitDefender Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants