Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jamf Protect] Enhancements and added dashboard for Telemetry #10279

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

txhaflaire
Copy link
Contributor

Type of change:

  • Enhancement

Proposed commit message

  • Added new Dashboard related to Telemetry data stream provided by Jamf Protect.
  • Updated some events and pipelines

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

elastic-package test system

2024/06/27 10:47:56  INFO Write container logs to file: /Users/thijs.xhaflaire/Documents/GitHub/Elastic/integrations/build/container-logs/jamf-protect-webtraffic-http-endpoint-1719478076140462000.log
--- Test results for package: jamf_protect - START ---
╭──────────────┬────────────────────┬───────────┬───────────────┬────────┬────────────────╮
│ PACKAGE      │ DATA STREAM        │ TEST TYPE │ TEST NAME     │ RESULT │   TIME ELAPSED │
├──────────────┼────────────────────┼───────────┼───────────────┼────────┼────────────────┤
│ jamf_protect │ alerts             │ system    │ http-endpoint │ PASS   │ 1m3.613952958s │
│ jamf_protect │ telemetry          │ system    │ http-endpoint │ PASS   │ 1m2.010388209s │
│ jamf_protect │ telemetry_legacy   │ system    │ http-endpoint │ PASS   │  1m0.03619975s │
│ jamf_protect │ web_threat_events  │ system    │ http-endpoint │ PASS   │  59.141154542s │
│ jamf_protect │ web_traffic_events │ system    │ http-endpoint │ PASS   │  1m1.34401175s │
╰──────────────┴────────────────────┴───────────┴───────────────┴────────┴────────────────╯
--- Test results for package: jamf_protect - END   ---
Done

@txhaflaire txhaflaire requested a review from a team as a code owner June 27, 2024 08:52
@efd6
Copy link
Contributor

efd6 commented Jun 27, 2024

/test

@efd6
Copy link
Contributor

efd6 commented Jun 27, 2024

Can you post a screen shot of the dashboard?

@txhaflaire
Copy link
Contributor Author

@efd6 Sure!

image
image
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two images will need to have references in the screenshots list in the package manifest.yml.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efd6 check - just pushed an update to the manifest.yml file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text block at the bottom of this screenshot, is it related to a visualisation? Similar query about the "Authentications and Authorizations" and the "Process Executions" texts in the second screenshot here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efd6 Yes - the text blocks do explain the visualisation and why that piece of information is relevant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to understand which text goes with which visualisation. If the text below the visualisation explains it, could it go in the text box to the left of it? The current layout doesn't make it immediately obvious what things are connected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efd6 maybe this scrolling-screenshots helps as it shows the complete dashboard.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I think I have it. The floating boxes are supposed to be headings for the things below them. Is that correct? This is a bit confusing since there is no equivalently styled heading for the other sections. The following is how I interpret it (red boxes form groups).

jamf-suggest

Can you also fix up the widget alignments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efd6 pushed up the new dashboard and screenshots.

image

@efd6
Copy link
Contributor

efd6 commented Jul 1, 2024

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6
Copy link
Contributor

efd6 commented Jul 1, 2024

/test

@efd6
Copy link
Contributor

efd6 commented Jul 2, 2024

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants