-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jamf Protect] Enhancements and added dashboard for Telemetry #10279
base: main
Are you sure you want to change the base?
Conversation
/test |
Can you post a screen shot of the dashboard? |
@efd6 Sure! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two images will need to have references in the screenshots
list in the package manifest.yml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@efd6 check - just pushed an update to the manifest.yml file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text block at the bottom of this screenshot, is it related to a visualisation? Similar query about the "Authentications and Authorizations" and the "Process Executions" texts in the second screenshot here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@efd6 Yes - the text blocks do explain the visualisation and why that piece of information is relevant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to understand which text goes with which visualisation. If the text below the visualisation explains it, could it go in the text box to the left of it? The current layout doesn't make it immediately obvious what things are connected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@efd6 maybe this scrolling-screenshots helps as it shows the complete dashboard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I think I have it. The floating boxes are supposed to be headings for the things below them. Is that correct? This is a bit confusing since there is no equivalently styled heading for the other sections. The following is how I interpret it (red boxes form groups).
Can you also fix up the widget alignments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@efd6 pushed up the new dashboard and screenshots.
/test |
🚀 Benchmarks reportTo see the full report comment with |
/test |
/test |
💚 Build Succeeded
History
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Type of change:
Proposed commit message
Checklist
changelog.yml
file.How to test this PR locally
elastic-package test system