-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mimecast: add support for v2 API endpoints #11782
Open
efd6
wants to merge
12
commits into
elastic:main
Choose a base branch
from
efd6:10974-mimecast
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+6,477
−690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
enhancement
New feature or request
breaking change
Integration:mimecast
Mimecast
Team:Security-Service Integrations
Security Service Integrations Team [elastic/security-service-integrations]
labels
Nov 20, 2024
efd6
force-pushed
the
10974-mimecast
branch
3 times, most recently
from
November 20, 2024 02:02
1776041
to
3297912
Compare
* archive_search_logs * dlp_logs * ttp_ap_logs * ttp_ip_logs * ttp_url_logs
10 tasks
🚀 Benchmarks reportTo see the full report comment with |
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
5 tasks
💚 Build Succeeded
History
cc @efd6 |
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
enhancement
New feature or request
Integration:mimecast
Mimecast
Team:Security-Service Integrations
Security Service Integrations Team [elastic/security-service-integrations]
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Note
The addition of siem_logs v2 support depends in a stack upgrade, so that will be done in a future PR so that users on v8.14.x can get the benefit of the v2 change for the other endpoints.
Note
Test vectors for the ttp_ip_logs were not available from the test instance. If they become available they will be added. In the meantime, the change here uses v1 data via a v2 API call structure. This is likely OK since the majority of v2 data shapes match the v1 shape.
Note
Best reviewed commit-wise.
The commits can be grouped in to families:
Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots
Default state (minimised)
Mimecast v1 data streams
Mimecast v2 data streams