Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimecast: add support for v2 API endpoints #11782

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Nov 20, 2024

Proposed commit message

Migrate the message_release_logs agent to the Mimecast v2 API and add v2 API
agents for:

* archive_search_logs
* audit_events
* dlp_logs
* threat_intel_malware_customer
* threat_intel_malware_grid
* ttp_ap_logs
* ttp_ip_logs
* ttp_url_logs

The migration of message_release_logs means that this is a breaking change.

Note

The addition of siem_logs v2 support depends in a stack upgrade, so that will be done in a future PR so that users on v8.14.x can get the benefit of the v2 change for the other endpoints.

Note

Test vectors for the ttp_ip_logs were not available from the test instance. If they become available they will be added. In the meantime, the change here uses v1 data via a v2 API call structure. This is likely OK since the majority of v2 data shapes match the v1 shape.

Note

Best reviewed commit-wise.

The commits can be grouped in to families:

  • common:
    • archive_search_logs
    • dlp_logs
    • message_release_logs
    • ttp_ap_logs
    • ttp_ip_logs
    • ttp_url_logs
  • audit
    • audit_events
  • malware:
    • threat_intel_malware_customer
    • threat_intel_malware_grid

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Default state (minimised)

Screenshot from 2024-11-21 08-08-45

Mimecast v1 data streams

Screenshot from 2024-11-21 08-09-25

Mimecast v2 data streams

Screenshot from 2024-11-21 08-09-46

@efd6 efd6 added enhancement New feature or request breaking change Integration:mimecast Mimecast Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Nov 20, 2024
@efd6 efd6 self-assigned this Nov 20, 2024
@efd6 efd6 force-pushed the 10974-mimecast branch 3 times, most recently from 1776041 to 3297912 Compare November 20, 2024 02:02
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review November 20, 2024 03:46
@efd6 efd6 requested a review from a team as a code owner November 20, 2024 03:46
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request Integration:mimecast Mimecast Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants