Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Teleport] Update based on internal feedback #11791

Closed
wants to merge 2 commits into from

Conversation

ilyannn
Copy link
Contributor

@ilyannn ilyannn commented Nov 20, 2024

Proposed commit message

Resolves the issues found when the Teleport integration was reviewed internally:

  • Fix teleport.audit.kubernetes.groups and similar feld type
  • Handle situation when host.name already exists

We also implement the following quality-of-life improvements:

  • Added tags and descriptions for processors.
  • Switched to append processors instead of rename wherever fields from different groups may collide.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ilyannn ilyannn added bug Something isn't working, use only for issues enhancement New feature or request labels Nov 20, 2024
@ilyannn ilyannn self-assigned this Nov 20, 2024
@andrewkroh andrewkroh added bugfix Pull request that fixes a bug issue Integration:teleport Teleport and removed bug Something isn't working, use only for issues labels Nov 20, 2024
@elasticmachine
Copy link

elasticmachine commented Nov 20, 2024

💔 Build Failed

Failed CI Steps

History

cc @ilyannn

@ilyannn ilyannn changed the title [Teleport] Apply feedback [Teleport] Fixes from the internal feedback Nov 20, 2024
@ilyannn ilyannn changed the title [Teleport] Fixes from the internal feedback [Teleport] Update based on internal feedback Nov 20, 2024
@botelastic
Copy link

botelastic bot commented Dec 20, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Dec 20, 2024
@botelastic
Copy link

botelastic bot commented Jan 19, 2025

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Jan 19, 2025
@ilyannn ilyannn deleted the teleport/apply-feedback branch February 7, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue enhancement New feature or request Integration:teleport Teleport Stalled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants