Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test packages mappings - DO NOT MERGE #12300

Draft
wants to merge 55 commits into
base: main
Choose a base branch
from

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Jan 10, 2025

Relates #3935

Do tests in the packages failed when using the validation based on mappings.

@mrodm mrodm self-assigned this Jan 10, 2025
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jan 10, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

mrodm added 7 commits January 14, 2025 18:04
Re-generate sample_event file since there were errors related to a
field missing the expected type (auditd.data.audit_pid). This was not
failing previously probably because "auditd.data" was declared as
flattened, and that is skipped in validation.
Comment on lines +4 to +7
- external: ecs
name: threat.enrichments.indicator.first_seen
- external: ecs
name: threat.enrichments.indicator.last_seen
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously they were mapped as keyword, with this change they would be date.

Comment on lines +4 to +6
- external: ecs
name: threat.indicator.modified_at

Copy link
Contributor Author

@mrodm mrodm Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously they were mapped as keyword, with this change they would be date.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @mrodm

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
72.9% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@@ -27,7 +27,7 @@
type: long
- name: AsepWrittenCount
type: long
- name: assessments.*
- name: assessments
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definition was generating a dynamic template to transform objects to flattened, and it was not recognizing the fields under assessments like assessments.application_firewall_mac.

@@ -82,7 +82,7 @@
metric_type: gauge
description: |
The percentage of used swap memory.
- name: vmstat.*
- name: vmstat
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definition was generating a dynamic template to transform objects to flattened, and it was not recognizing the fields under vmstats like vmstats.allocstall_device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants