-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Elastic Agent] Updates to Elastic Agent metrics dashboards #12793
base: main
Are you sure you want to change the base?
[Elastic Agent] Updates to Elastic Agent metrics dashboards #12793
Conversation
💚 Build Succeeded
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question on the interval, one title with "copy" in it.
But overall looks ok to me.
"y": 9 | ||
}, | ||
"panelIndex": "e3042c9b-987d-41fa-bc6b-0a73565ef278", | ||
"title": "[Elastic Agent] Number of Integrations (copy)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if this is actually visible to the end user or not (didn't see it in screenshots), but we probably don't want copy in the title.
@@ -720,7 +4598,7 @@ | |||
"params": { | |||
"dropPartials": true, | |||
"includeEmptyRows": false, | |||
"interval": "m" | |||
"interval": "auto" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think for anything that is a counter rate we want to keep the interval at "m" or "30s", we don't get the data very frequently and you don't want your interval to not have records in it to perform the counter rate, that leads to very odd looking graphs. Unless something in Kibana has fixed this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@strawgate do you have any tip/trick to add data to populate test the dashboard?
The screenshots look good, but I'm not sure I can easily generate data to populate all dashboards.
@@ -1,9 +1,9 @@ | |||
# newer versions go on top | |||
- version: "2.0.4" | |||
- version: "2.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you edited the last changelog entry instead of adding a new one.
Fixes #12488
Replaces closed PR: #12524
Benefits from:
Checklist
changelog.yml
file.Author's Checklist
Related issues
Screenshots
Overview
Concerning Agents
Agent Metrics