Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Elastic Agent] Updates to Elastic Agent metrics dashboards #12793

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

strawgate
Copy link
Contributor

Fixes #12488

Replaces closed PR: #12524

Benefits from:

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

Related issues

Screenshots

Overview

Overview

Concerning Agents

Problematic Agents

Agent Metrics

Agent Metrics

@strawgate strawgate requested a review from a team as a code owner February 14, 2025 19:04
@strawgate strawgate enabled auto-merge (squash) February 14, 2025 19:04
@strawgate strawgate disabled auto-merge February 14, 2025 19:04
@strawgate strawgate enabled auto-merge (squash) February 14, 2025 19:05
@elasticmachine
Copy link

💚 Build Succeeded

Copy link

Quality Gate failed Quality Gate failed

Failed conditions
75.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane] label Feb 18, 2025
@elasticmachine
Copy link

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question on the interval, one title with "copy" in it.

But overall looks ok to me.

"y": 9
},
"panelIndex": "e3042c9b-987d-41fa-bc6b-0a73565ef278",
"title": "[Elastic Agent] Number of Integrations (copy)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is actually visible to the end user or not (didn't see it in screenshots), but we probably don't want copy in the title.

@@ -720,7 +4598,7 @@
"params": {
"dropPartials": true,
"includeEmptyRows": false,
"interval": "m"
"interval": "auto"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for anything that is a counter rate we want to keep the interval at "m" or "30s", we don't get the data very frequently and you don't want your interval to not have records in it to perform the counter rate, that leads to very odd looking graphs. Unless something in Kibana has fixed this.

Copy link
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strawgate do you have any tip/trick to add data to populate test the dashboard?

The screenshots look good, but I'm not sure I can easily generate data to populate all dashboards.

@@ -1,9 +1,9 @@
# newer versions go on top
- version: "2.0.4"
- version: "2.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems you edited the last changelog entry instead of adding a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team [elastic/elastic-agent-data-plane]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[elastic_agent] Improvements to the Elastic Agent Metrics Overview dashboard
5 participants