Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename datasources to config_templates #132

Merged
merged 5 commits into from
Jun 30, 2020
Merged

Rename datasources to config_templates #132

merged 5 commits into from
Jun 30, 2020

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Jun 30, 2020 •
edited
Loading

This renames the datasources: part in the dataset manifest to config_templates:.

@ruflin ruflin self-assigned this Jun 30, 2020
@ruflin
Copy link
Member Author

ruflin commented Jun 30, 2020

This requires elastic/package-registry#570 to be merged first and then the dependency is updated to update the last two usages of DataSources.

@ruflin ruflin mentioned this pull request Jun 30, 2020
Closed
29 tasks
@elasticmachine
Copy link

elasticmachine commented Jun 30, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #132 updated]

  • Start Time: 2020-06-30T09:27:49.990+0000

  • Duration: 2 min 21 sec

mtojek
mtojek reviewed Jun 30, 2020
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the file datasources.go needs to be renamed.

@mtojek mtojek mentioned this pull request Jun 30, 2020
Merged
11 tasks
@ruflin
Copy link
Member Author

ruflin commented Jun 30, 2020 •
edited
Loading

@mtojek good catch, fixed. Wrong thread, but will update the datasources.go

@mtojek mtojek self-requested a review June 30, 2020 07:34
mtojek
mtojek approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but need to track if somebody pushes an incompatible package.

@ruflin
Copy link
Member Author

ruflin commented Jun 30, 2020

@mtojek Updated again with quite a few more changes I found.

Is CI validating of the imports-beat code is valid?

@mtojek
Copy link
Contributor

mtojek commented Jun 30, 2020

Is CI validating of the imports-beat code is valid?

Nope, unfortunately it doesn't. It wasn't urgent so far (also the future of this script is blurry).

Side note: there was Kubernetes integration pushed to master. I think you need to rebase your PR.

@ruflin ruflin requested a review from mtojek June 30, 2020 09:27
@ruflin
Copy link
Member Author

ruflin commented Jun 30, 2020

@mtojek Rebased and updated with most recent packages.

@ruflin ruflin merged commit 8836aa5 into elastic:master Jun 30, 2020
@ruflin ruflin deleted the config_templates branch June 30, 2020 09:59
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@ruflin
Rename datasources to config_templates (elastic#132)
97229a9 
This renames the `datasources:` part in the dataset manifest to `config_tempaltes:`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@ruflin ruflin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruflin @elasticmachine @mtojek