-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubernetes namespace field. breaking change #1792
Update kubernetes namespace field. breaking change #1792
Conversation
Pinging @elastic/integrations (Team:Integrations) |
This needs to be merged after elastic/beats#27917 is merged |
@@ -1,7 +1,7 @@ | |||
format_version: 1.0.0 | |||
name: kubernetes | |||
title: Kubernetes | |||
version: 1.1.0 | |||
version: 1.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is a breaking change, you should go with 2.0.0
packages/kubernetes/data_stream/controllermanager/fields/base-fields.yml
Show resolved
Hide resolved
- version: "1.2.0" | ||
changes: | ||
- description: Update Kubernetes namespace field | ||
type: enhancement |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type: breaking-change
?
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
Can you share some details on how a user is upgrading from 7.x to 8.0 and the order a user would upgrade? I see now changes to the ingest pipeline in this PR but would have expected the ingest pipeline to provide some backward compatbility. |
@mtojek I added the ingest pipelines to support old agent versions as well! I think that now it is not considered a breaking change for the package anymore. So we don't need to set the version to 2.0 and we can remove the |
@ruflin I expect that the upgrade process goes like this:
Between steps 1 and 2 there will be 7.x agents sending data to 8.0 stack at the same time with 8.0 agents. |
I assume step 1.5 is that the user also needs to ensure to have the most recent k8s package version. |
I have exactly the same understanding. Please proceed with these changes (lower version, no breaking changes). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some Git conflicts here.
@mtojek I resolved them |
* Use pipeline to rename fileds in cases of agents 7.x and stack ^8.x
What does this PR do?
In agent 8.0 a new breaking changed is introduced.
As part of elastic/beats#16483 and after merging of elastic/beats#27917
following changes where introduced:
kubernetes.namespace
from keyword to group field.kubernetes.namespace
which was the name of the namespace tokubernetes.namespace.name
field.namespace_labels
,namespace_annotations
namespace_uid
metadata tonamespace.labels
,namespace.annotations
,namespace.uid
.kubernetes integration must also be updated accordingly to support the updated fields.
An ingest pipeline is also added in each updated data_stream to support also agents before 8.0 which may also send data to 8.0 stack. This can happen due to the update process of each user.
In this PR
Kubernetes namespace
field gets updated from keyword to group type andname
,labels
,annotations
,uid
are added as fields under it.Checklist
changelog.yml
file.manifest.yml
file to point to the latest Elastic stack release (e.g.^7.13.0
).##Screenshots