Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Atlassian Bitbucket Readme #3061

Merged
merged 6 commits into from
Apr 27, 2022
Merged

Update Atlassian Bitbucket Readme #3061

merged 6 commits into from
Apr 27, 2022

Conversation

ellis-elastic
Copy link
Contributor

@ellis-elastic ellis-elastic commented Apr 11, 2022 •
edited
Loading

Added link to Atlassian's documentation

Type of change

  • Enhancement

What does this PR do?

Added link to Atlassian's documentation

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@GinnyGalicia
Update Readme
082aa01 
Added link to Atlassian's documentation
@ellis-elastic ellis-elastic requested a review from a team as a code owner April 11, 2022 15:30
@elasticmachine
Copy link

elasticmachine commented Apr 11, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-27T20:36:25.687+0000

  • Duration: 14 min 2 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@efd6
Copy link
Contributor

efd6 commented Apr 12, 2022

/test

@r00tu53r r00tu53r added documentation Improvements or additions to documentation Team:Security-External Integrations Integration:atlassian_bitbucket Atlassian Bitbucket labels Apr 12, 2022
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

andrewkroh
andrewkroh previously approved these changes Apr 12, 2022
View reviewed changes
@andrewkroh andrewkroh dismissed their stale review April 12, 2022 12:18

CI is failing with "Format the package"

@ellis-elastic
Update readme
050da02 
Added link to documentation for 7.18.1 and a link on auditing in Bitbucket and how it can be configured
@ellis-elastic
Ran elastic-package build
530bf53
@r00tu53r
Copy link
Contributor

LGTM. The changelog.yml seems to have formatting errors. Please run elastic-package format and commit the changes. I think its good to merge after the CI passes.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 2.857
Classes 100.0% (1/1) 💚 2.857
Methods 100.0% (13/13) 💚 11.905
Lines 98.649% (365/370) 👍 9.811
Conditionals 100.0% (0/0) 💚

@bmorelli25 bmorelli25 merged commit 3abc6ee into elastic:main Apr 27, 2022
@andrewkroh andrewkroh mentioned this pull request May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r00tu53r r00tu53r r00tu53r approved these changes

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@andrewkroh andrewkroh andrewkroh left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation Integration:atlassian_bitbucket Atlassian Bitbucket
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ellis-elastic @elasticmachine @efd6 @r00tu53r @andrewkroh @bmorelli25 @GinnyGalicia