Add pipeline tests to Cisco ASA #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing field definitions. Correct JSON data types for fields. - event.code - network.iana_number TODO: Fix warnings: [0] parsing field value failed: field "destination.port"''s Go type, string, does not match the expected field type: long [1] parsing field value failed: field "source.port"''s Go type, string, does not match the expected field type: long cisco/asa test-not-ip.log: [0] parsing field value failed: field "destination.nat.port"''s Go type, string, does not match the expected field type: long [1] parsing field value failed: field "source.nat.port"''s Go type, string, does not match the expected field type: long [2] parsing field value failed: field "syslog.facility"''s Go type, float64, does not match the expected field type: keyword cisco/asa test-sample.log: [0] parsing field value failed: field "source.nat.port"''s Go type, string, does not match the expected field type: long Fix error.message in generated pipeline.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
|
This requires elastic/elastic-package#193 |
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
leehinman
approved these changes
Dec 14, 2020
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Jan 11, 2021
andrewkroh
added a commit
to elastic/beats
that referenced
this pull request
Jan 25, 2021
* Sync changes to AWS CloudTrail elastic/integrations#408 * Sync changes to CheckPoint Firewall Change type of event.severity. elastic/integrations#409 * Sync changes from Cisco ASA / FTD elastic/integrations#414 * Sync changes from Cisco IOS Make icmp and igmp fields strings because they are keywords. elastic/integrations#416 * Sync changes to CrowdStrike Falcon Fix some field types. elastic/integrations#377 * Sync changes to Fortinet Firewall Drop assignip if the value is "N/A". elastic/integrations#437 * Sync changes to Juniper SRX Convert event.risk values to float Protect against missing event.timezone Convert event.severity to long. elastic/integrations#443 * Sync changes to Suricata EVE Convert suricata.eve.flow_id to string because the field is a keyword in the mapping. elastic/integrations#457 * Sync changes to Zeek DNS Fix usages of ignore_failure with convert processor. Make DNS transaction ID a string. elastic/integrations#448 * Add changelog
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Feb 16, 2021
* Sync changes to AWS CloudTrail elastic/integrations#408 * Sync changes to CheckPoint Firewall Change type of event.severity. elastic/integrations#409 * Sync changes from Cisco ASA / FTD elastic/integrations#414 * Sync changes from Cisco IOS Make icmp and igmp fields strings because they are keywords. elastic/integrations#416 * Sync changes to CrowdStrike Falcon Fix some field types. elastic/integrations#377 * Sync changes to Fortinet Firewall Drop assignip if the value is "N/A". elastic/integrations#437 * Sync changes to Juniper SRX Convert event.risk values to float Protect against missing event.timezone Convert event.severity to long. elastic/integrations#443 * Sync changes to Suricata EVE Convert suricata.eve.flow_id to string because the field is a keyword in the mapping. elastic/integrations#457 * Sync changes to Zeek DNS Fix usages of ignore_failure with convert processor. Make DNS transaction ID a string. elastic/integrations#448 * Add changelog (cherry picked from commit bf46572)
adriansr
pushed a commit
to elastic/beats
that referenced
this pull request
Feb 17, 2021
#24077) * Sync fixes from Integration Package Testing (#23424) * Sync changes to AWS CloudTrail elastic/integrations#408 * Sync changes to CheckPoint Firewall Change type of event.severity. elastic/integrations#409 * Sync changes from Cisco ASA / FTD elastic/integrations#414 * Sync changes from Cisco IOS Make icmp and igmp fields strings because they are keywords. elastic/integrations#416 * Sync changes to CrowdStrike Falcon Fix some field types. elastic/integrations#377 * Sync changes to Fortinet Firewall Drop assignip if the value is "N/A". elastic/integrations#437 * Sync changes to Juniper SRX Convert event.risk values to float Protect against missing event.timezone Convert event.severity to long. elastic/integrations#443 * Sync changes to Suricata EVE Convert suricata.eve.flow_id to string because the field is a keyword in the mapping. elastic/integrations#457 * Sync changes to Zeek DNS Fix usages of ignore_failure with convert processor. Make DNS transaction ID a string. elastic/integrations#448 * Add changelog (cherry picked from commit bf46572)
eyalkraft
pushed a commit
to build-security/integrations
that referenced
this pull request
Mar 30, 2022
* Add pipeline test to Cisco ASA Add missing field definitions. Correct JSON data types for fields. - event.code - network.iana_number TODO: Fix warnings: [0] parsing field value failed: field "destination.port"''s Go type, string, does not match the expected field type: long [1] parsing field value failed: field "source.port"''s Go type, string, does not match the expected field type: long cisco/asa test-not-ip.log: [0] parsing field value failed: field "destination.nat.port"''s Go type, string, does not match the expected field type: long [1] parsing field value failed: field "source.nat.port"''s Go type, string, does not match the expected field type: long [2] parsing field value failed: field "syslog.facility"''s Go type, float64, does not match the expected field type: keyword cisco/asa test-sample.log: [0] parsing field value failed: field "source.nat.port"''s Go type, string, does not match the expected field type: long Fix error.message in generated pipeline. * Check for unset raw_date temp field. * Convert NAT ports to integer * Upgrade ASA pipeline from Beats * Fix internal prefix * Fixes to the pipeline and remove bad test lines * Missing fields * Regenerate golden files * config to ignore event.ingested * Update Cisco package to 0.8.0 * Mage fmt * Update docs fields * Use test case configuration to set numeric keywords * Run `elastic-package format` * Update dependencies Co-authored-by: Adrian Serrano <adrisr83@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add missing field definitions.
Correct JSON data types for fields.
TODO
Checklist
How to test this PR locally
Related issues