Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nginx TSDB Enablement #5315

Merged
merged 8 commits into from
Mar 16, 2023
Merged

Nginx TSDB Enablement #5315

merged 8 commits into from
Mar 16, 2023

Conversation

agithomas
Copy link
Contributor

Type of change

  • Enhancement

What does this PR do?

TSDB Enablement for Nginx

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@agithomas agithomas requested a review from a team as a code owner February 18, 2023 11:42
@elasticmachine
Copy link

elasticmachine commented Feb 18, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-16T10:33:03.414+0000

  • Duration: 17 min 40 sec

Test stats 🧪

Test Results
Failed 0
Passed 40
Skipped 0
Total 40

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Feb 18, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 50.0% (2/4) ❕
Classes 50.0% (2/4) ❕
Methods 69.231% (27/39) ❕
Lines 70.37% (228/324) ❕
Conditionals 100.0% (0/0) 💚

@agithomas agithomas mentioned this pull request Feb 19, 2023
Closed
6 tasks
@lalit-satapathy
Copy link
Collaborator

Can we remove Oracle package relevant changes from this PR? This PR is only for Nginx changes.

@agithomas agithomas force-pushed the issue-5282-nginx-tsdb branch from d306ed9 to 07e5db0 Compare February 20, 2023 12:40
muthu-mps
muthu-mps reviewed Feb 21, 2023
View reviewed changes
packages/nginx/data_stream/stubstatus/fields/fields.yml
description: |
The total number of client requests.
- name: current
type: long
metric_type: gauge
description: |
The current number of client requests.
- name: reading
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of the TSDB change, Do we need to change the avg to max ? I didn't see this change for stubstatus visualisations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer here

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please check for this visualisation - Reading / Writing / Waiting Rates [Metrics Nginx]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is needed only when the metric_type is counter. metric_typehaving valuecounter does not supportavgat present. Hence the change only for thecounter` metric_type fields only.

@agithomas agithomas self-assigned this Feb 21, 2023
@agithomas agithomas force-pushed the issue-5282-nginx-tsdb branch from d645183 to 1273199 Compare February 28, 2023 09:09
ritalwar
ritalwar approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas merged commit 84815e4 into elastic:main Mar 16, 2023
@elasticmachine
Copy link

Package nginx - 1.8.0 containing this change is available at https://epr.elastic.co/search?package=nginx

agithomas added a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
@agithomas
Nginx TSDB Enablement (elastic#5315)
74e2fe4 
* Nginx TSDB Enablement

* Added inline comment on dimension fields
agithomas added a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@agithomas
Nginx TSDB Enablement (elastic#5315)
b56cd97 
* Nginx TSDB Enablement

* Added inline comment on dimension fields
@kpollich kpollich mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muthu-mps muthu-mps muthu-mps left review comments

@ritalwar ritalwar ritalwar approved these changes

Assignees

@agithomas agithomas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@agithomas @elasticmachine @lalit-satapathy @muthu-mps @ritalwar