Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][HAProxy] Migrate log data-stream visualizations to lens in kibana 8.4.0 #5610

Merged
merged 8 commits into from
Oct 26, 2023
Merged

[O11y][HAProxy] Migrate log data-stream visualizations to lens in kibana 8.4.0 #5610

merged 8 commits into from
Oct 26, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Mar 21, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate log data-stream visualizations to lens for HAProxy integration package

  • Statistics for HAProxy Lens migration:

HAProxy dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Logs HAProxy] Overview 0 3 3 0
  0 3 3 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.4.0 itself.

Related issues

Note: Please find below screenshots of dashboards (before migration) to compare migrated panels:

[Logs HAProxy] Overview:
image

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 21, 2023 12:17
@agithomas
Copy link
Contributor

Can you please confirm if the GeoMap works. Does it have multilayers? Since there are no data represented over the map, i can't figure out.

@elasticmachine
Copy link

elasticmachine commented Mar 21, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-25T13:30:58.209+0000

  • Duration: 16 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Mar 21, 2023
Closed
6 tasks
@elasticmachine
Copy link

elasticmachine commented Mar 21, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 90.476% (19/21) ❕
Lines 97.312% (181/186) ❕
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22
Copy link
Contributor Author

Can you please confirm if the GeoMap works. Does it have multilayers? Since there are no data represented over the map, i can't figure out.

Yes @agithomas. The GeoMap is working and it has one layer which represents unique count of source.address.

Please find below screenshot for IP Geohashes [Logs HAProxy] panel:
image

agithomas
agithomas approved these changes Mar 21, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Contributor

Please complete the peer review.

@kush-elastic kush-elastic self-requested a review March 22, 2023 11:27
@kush-elastic kush-elastic added enhancement New feature or request v8.4.0 Team:Service-Integrations Label for the Service Integrations team Integration:haproxy HAProxy labels Mar 22, 2023
kush-elastic
kush-elastic approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@botelastic
Copy link

botelastic bot commented May 16, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label May 16, 2023
@botelastic
Copy link

botelastic bot commented Jun 15, 2023

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Jun 15, 2023
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner June 29, 2023 07:27
@botelastic botelastic bot removed the Stalled label Jun 29, 2023
@botelastic
Copy link

botelastic bot commented Jul 29, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jul 29, 2023
@botelastic
Copy link

botelastic bot commented Aug 28, 2023

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Aug 28, 2023
@botelastic botelastic bot removed the Stalled label Oct 17, 2023
@rajvi-patel-22
Merge branch 'main' of https://github.com/rajvi-elastic/integrations …
1e76ff6 
…into lens_migration-haproxy-log-8.4.0

Conflicts:
	packages/haproxy/changelog.yml
	packages/haproxy/manifest.yml
@rajvi-patel-22
Merge branch 'main' of https://github.com/rajvi-elastic/integrations …
9e8dab7 
…into lens_migration-haproxy-log-8.4.0

Conflicts:
	packages/haproxy/changelog.yml
@rajvi-patel-22
Update manifest
48b5a78
agithomas
agithomas approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit 90ce86e into elastic:main Oct 26, 2023
1 check passed
@elasticmachine
Copy link

Package haproxy - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=haproxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milan-elastic milan-elastic milan-elastic approved these changes

@agithomas agithomas agithomas approved these changes

@kush-elastic kush-elastic kush-elastic approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:haproxy HAProxy Team:Service-Integrations Label for the Service Integrations team v8.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajvi-patel-22 @agithomas @elasticmachine @kush-elastic @milan-elastic