Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][WebSphere Application Server] Migrate Session Manager and Servlet dashboard visualizations to lens in Kibana 8.3.0 #5633

Merged
merged 3 commits into from
Mar 24, 2023
Merged

[O11y][WebSphere Application Server] Migrate Session Manager and Servlet dashboard visualizations to lens in Kibana 8.3.0 #5633

merged 3 commits into from
Mar 24, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Migrate 'Session Manager' and 'Servlet' data-streams visualizations to lens for WebSphere Application Server integration package

  • Statistics for WebSphere Application Server Lens migration:

WebSphere Application Server dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics WebSphere Application Server] Session Manager 4 1 4 0
[Metrics WebSphere Application Server] Servlet 3 0 3 0
  7 1 7 0
Note: Migrate 1 visualization to new control panel.

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.3.0 itself.

Related issues

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner March 22, 2023 08:32
This was referenced Mar 22, 2023
Closed
Closed
@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-24T04:56:40.428+0000

  • Duration: 28 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 37
Skipped 0
Total 37

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (28/28) 💚
Lines 100.0% (488/488) 💚
Conditionals 100.0% (0/0) 💚

agithomas
agithomas approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Contributor

Please complete Peer review before merge.

@kush-elastic kush-elastic self-requested a review March 22, 2023 11:19
@kush-elastic kush-elastic added enhancement New feature or request v8.3.0 Team:Service-Integrations Label for the Service Integrations team Integration:websphere_application_server WebSphere Application Server labels Mar 22, 2023
kush-elastic
kush-elastic approved these changes Mar 22, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kush-elastic kush-elastic merged commit c7172c7 into elastic:main Mar 24, 2023
@elasticmachine
Copy link

Package websphere_application_server - 0.6.0 containing this change is available at https://epr.elastic.co/search?package=websphere_application_server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

@kush-elastic kush-elastic kush-elastic approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:websphere_application_server WebSphere Application Server Team:Service-Integrations Label for the Service Integrations team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rajvi-patel-22 @elasticmachine @agithomas @kush-elastic