Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][Apache] Migrate Access and error logs dashboard visualizations to lens in kibana 8.3.0 #5635

Merged
merged 6 commits into from
Apr 11, 2023
Merged

[O11y][Apache] Migrate Access and error logs dashboard visualizations to lens in kibana 8.3.0 #5635

merged 6 commits into from
Apr 11, 2023

Conversation

harnish-elastic
Copy link
Contributor

@harnish-elastic harnish-elastic commented Mar 22, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Apache integration package

  • Statistics for Apache Lens migration:

Apache Dashboards Before Migration     After Migration    
  Maps Lens Visualization Maps Lens Visualization
[Logs Apache] Access and error logs 1 0 6 1 6 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.3.0 itself.

Related issues

@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-11T05:09:38.399+0000

  • Duration: 16 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 25
Skipped 0
Total 25

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 22, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 50.0% (2/4) 👎 -46.796
Classes 50.0% (2/4) 👎 -46.796
Methods 70.0% (28/40) 👎 -21.333
Lines 70.234% (210/299) 👎 -21.044
Conditionals 100.0% (0/0) 💚

@kush-elastic kush-elastic added enhancement New feature or request v8.3.0 Team:Service-Integrations Label for the Service Integrations team Integration:apache Apache HTTP Server labels Mar 22, 2023
@harnish-elastic harnish-elastic marked this pull request as ready for review March 22, 2023 13:04
@harnish-elastic harnish-elastic requested a review from a team as a code owner March 22, 2023 13:04
@agithomas
Copy link
Contributor

@SubhrataK , please assess the significance of the issue reported as "Not having feature to set last bucket value" . If it is relevant enough, we may need to wait until Lens resolves the issue.

@harnish-elastic harnish-elastic mentioned this pull request Mar 22, 2023
Closed
6 tasks
@SubhrataK
Copy link

SubhrataK commented Mar 27, 2023 •
edited
Loading

@SubhrataK , please assess the significance of the issue reported as "Not having feature to set last bucket value" . If it is relevant enough, we may need to wait until Lens resolves the issue.

@agithomas As already discussed, with @harnish-elastic the value displayed in lens (without the selection of "Drop last bucket") is correct representation of data and hence we do not need that option. The same has been communicated in the issue you have mentioned above. We should go ahead with the migration.

@agithomas
Copy link
Contributor

@harnish-elastic , once you made the changes, resolved the merge conflicts, please ask for re-review

@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
4115c4f 
…into lens_migration-apache-logs-8.3.0

Conflicts:
	packages/apache/changelog.yml
	packages/apache/manifest.yml
@harnish-elastic
migrate pending visualizations for log dashboard
575f7b7
@harnish-elastic
Copy link
Contributor Author

@agithomas Updated the PR with converting split chart to table chart. Thanks!

agithomas
agithomas approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
d946ac0 
…into lens_migration-apache-logs-8.3.0

Conflicts:
	packages/apache/changelog.yml
@kush-elastic kush-elastic merged commit 1c35649 into elastic:main Apr 11, 2023
@elasticmachine
Copy link

Package apache - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=apache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

@kush-elastic kush-elastic kush-elastic approved these changes

@lalit-satapathy lalit-satapathy Awaiting requested review from lalit-satapathy

Assignees

@harnish-elastic harnish-elastic

Labels
enhancement New feature or request Integration:apache Apache HTTP Server Team:Service-Integrations Label for the Service Integrations team v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harnish-elastic @elasticmachine @agithomas @SubhrataK @kush-elastic