Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Hadoop] Remove (s) from Application dashboard visualization #5731

Conversation

harnish-elastic
Copy link
Contributor

  • Bug

What does this PR do?

  • Remove (s) from below Application dashboard visualizations:
    • The number of virtual cores the application has allocated [Metrics Hadoop]
    • The amount of memory the application has allocated [Metrics Hadoop]

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have added an entry to my package's changelog.yml file.

Related issues

@harnish-elastic harnish-elastic marked this pull request as ready for review March 29, 2023 09:50
@harnish-elastic harnish-elastic requested a review from a team as a code owner March 29, 2023 09:50
Minor nit to keep consistency with other changelog file entry
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

elasticmachine commented Mar 29, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-04T10:09:29.305+0000

  • Duration: 22 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 31
Skipped 0
Total 31

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Mar 29, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 100.0% (47/47) 💚 4.762
Lines 99.18% (605/610) 👍 4.375
Conditionals 100.0% (0/0) 💚

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (5/5) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 100.0% (47/47) 💚 8.696
Lines 99.18% (605/610) 👍 16.706
Conditionals 100.0% (0/0) 💚

@agithomas
Copy link
Contributor

Please update the PR link in the changelog.

@agithomas
Copy link
Contributor

Please add the unit of memory for "Available Memory" panel

@agithomas
Copy link
Contributor

Average elapsed time is shown in ms. Can you convert this to a more human readable state - sec / min / hour?

@harnish-elastic
Copy link
Contributor Author

Average elapsed time is shown in ms. Can you convert this to a more human readable state - sec / min / hour?

Kibana hasn't any functionality to convert ms to sec / min / hour or any human readable state. Also we have already raised an issue for the same. elastic/kibana#153378

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

Package hadoop - 0.7.1 containing this change is available at https://epr.elastic.co/search?package=hadoop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants