Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][Vsphere] Migrate Hosts Overview dashboard visualizations to lens in kibana 8.7.0 #5810

Merged
merged 2 commits into from
Apr 10, 2023
Merged

[O11y][Vsphere] Migrate Hosts Overview dashboard visualizations to lens in kibana 8.7.0 #5810

merged 2 commits into from
Apr 10, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Apr 6, 2023 •
edited
Loading

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Vsphere integration package

  • Statistics for Vsphere Hosts Overview Lens migration:

VSphere dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Metrics VSphere] Hosts Overview 0 7 7 0
0 7 7 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.7.0 itself.

Related issues

Note: Screenshot of before migration dashboard is not synced with Kibana files. Please find below screenshot to compare the migrated visualizations.
Metrics VSphere Hosts Overview (1)

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner April 6, 2023 12:01
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Apr 6, 2023
Closed
6 tasks
@kush-elastic kush-elastic added enhancement New feature or request Integration:vsphere VMware vSphere v8.7.0 Team:Service-Integrations Label for the Service Integrations team labels Apr 6, 2023
@elasticmachine
Copy link

elasticmachine commented Apr 6, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-06T12:08:13.576+0000

  • Duration: 17 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 17
Skipped 0
Total 17

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (18/18) 💚
Lines 89.13% (41/46) 👍 7.443
Conditionals 100.0% (0/0) 💚

agithomas
agithomas approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! as there exist no objection to migrate to 8.7.0

@agithomas
Copy link
Contributor

@rajvi-elastic , please complete the peer review

milan-elastic
milan-elastic approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@kush-elastic kush-elastic merged commit bbd5f44 into elastic:main Apr 10, 2023
@elasticmachine
Copy link

Package vsphere - 1.4.0 containing this change is available at https://epr.elastic.co/search?package=vsphere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milan-elastic milan-elastic milan-elastic approved these changes

@agithomas agithomas agithomas approved these changes

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
enhancement New feature or request Integration:vsphere VMware vSphere Team:Service-Integrations Label for the Service Integrations team v8.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rajvi-patel-22 @elasticmachine @agithomas @milan-elastic @kush-elastic