Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][Oracle] Migrate Overview dashboard visualizations to lens in kibana 8.6.0 #5817

Merged
merged 4 commits into from
Apr 13, 2023
Merged

[O11y][Oracle] Migrate Overview dashboard visualizations to lens in kibana 8.6.0 #5817

merged 4 commits into from
Apr 13, 2023

Conversation

harnish-elastic
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Oracle integration package

  • Statistics for Oracle Lens migration:

Oracle Dashboards Before Migration   After Migration
  Lens Visualization Lens Visualization
[Metrics Oracle] Overview 0 13 13 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in Kibana version 8.6.0.

Related issues

@harnish-elastic harnish-elastic marked this pull request as ready for review April 7, 2023 09:58
@harnish-elastic harnish-elastic requested a review from a team as a code owner April 7, 2023 09:58
@kush-elastic kush-elastic added enhancement New feature or request Integration:oracle Oracle v8.6.0 Team:Service-Integrations Label for the Service Integrations team labels Apr 7, 2023
@harnish-elastic harnish-elastic mentioned this pull request Apr 7, 2023
Closed
10 tasks
@elasticmachine
Copy link

elasticmachine commented Apr 7, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-04-13T12:11:03.308+0000

  • Duration: 30 min 59 sec

Test stats 🧪

Test Results
Failed 0
Passed 26
Skipped 0
Total 26

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 7, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (29/29) 💚
Lines 94.318% (249/264) ❕
Conditionals 100.0% (0/0) 💚

agithomas
agithomas reviewed Apr 8, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the dashboard populated using similated data or from oracle instance ? If simulated, i encourage you to use oracle instance or a oracle on docker

  1. Avg datfile size going up and down is not correct
  2. Suggest to use stacked version similar to what is present in the old screenshot. Lack of spaces between bars gives a wrong visual impression

@harnish-elastic
Copy link
Contributor Author

@agithomas Used oracle docker to generate the values and updated the screenshot. Thanks!

@agithomas
Copy link
Contributor

I assume, the dashboard is impacted by not having the feature mentioned here elastic/kibana#72711. Please confirm?

@harnish-elastic
Copy link
Contributor Author

I assume, the dashboard is impacted by not having the feature mentioned here elastic/kibana#72711. Please confirm?

We have carried the same behavior from visualizations to lens. Hence we haven't mentioned this issue. But yes, if we want to convert the values, the lens charts are impacted by the issue which you have mentioned.

agithomas
agithomas approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas
Copy link
Contributor

Please complete the peer review

kush-elastic
kush-elastic approved these changes Apr 13, 2023
View reviewed changes
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-elastic
Merge branch 'main' of https://github.com/harnish-elastic/integrations …
b37d038 
…into lens_migration-oracle-overview

Conflicts:
	packages/oracle/changelog.yml
	packages/oracle/manifest.yml
@kush-elastic kush-elastic merged commit 28434a0 into elastic:main Apr 13, 2023
@elasticmachine
Copy link

Package oracle - 1.17.0 containing this change is available at https://epr.elastic.co/search?package=oracle

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Nov 6, 2023
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agithomas agithomas agithomas approved these changes

@kush-elastic kush-elastic kush-elastic approved these changes

Assignees

@harnish-elastic harnish-elastic

Labels
enhancement New feature or request Integration:oracle Oracle Team:Service-Integrations Label for the Service Integrations team v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@harnish-elastic @elasticmachine @agithomas @kush-elastic