Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][MySQL] Migrate [Logs MySQL] Overview dashboard visualizations to lens in kibana 8.8.0 #5818

Merged

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Apr 7, 2023

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for MySQL integration package

  • Statistics for MySQL Lens migration:

MySQL dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization
[Logs MySQL] Overview 0 5 5 0
  0 5 5 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.6.0 itself.

Related issues

Note:

The Kibana files and before migration dashboard image is not synced. Please find below screenshot to compare before and after migrated panels.
Logs Mysql  Overview

@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner April 7, 2023 10:07
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Apr 7, 2023
6 tasks
@kush-elastic kush-elastic added enhancement New feature or request Integration:mysql MySQL v8.6.0 Team:Service-Integrations Label for the Service Integrations team labels Apr 7, 2023
@elasticmachine
Copy link

elasticmachine commented Apr 7, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-18T12:36:28.751+0000

  • Duration: 23 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 57
Skipped 0
Total 57

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Apr 7, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 92.857% (26/28) 👍 26.19
Lines 94.34% (150/159) 👎 -5.66
Conditionals 100.0% (0/0) 💚

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can u update the query time duration unit and convert to sec /min/ hour unit?

@agithomas
Copy link
Contributor

@lalit-satapathy , the version change is a steep jump to 8.6.0 for MySQL. Are there concerns?

@rajvi-elastic , can you please share the details what led to this steep jump?

@rajvi-patel-22
Copy link
Contributor Author

rajvi-patel-22 commented Apr 10, 2023

@rajvi-elastic , can you please share the details what led to this steep jump?

@agithomas, Below are the 3 panels which uses conditional operations (ifelse) which is supported in 8.6 and later versions.

[Metrics MySQL] Database Overview  Minimum Kibana Version Functionality
Buffer Pool Utilization 8.6.0 Adds conditional operations in the Lens formula
Buffer Pool Efficiency 8.6.0 Adds conditional operations in the Lens formula
Network Traffic 8.6.0 Adds conditional operations in the Lens formula

@rajvi-patel-22
Copy link
Contributor Author

Can u update the query time duration unit and convert to sec /min/ hour unit?

@agithomas, According to the field description, the values are in nanoseconds. Should we convert it to milliseconds or seconds?

@agithomas
Copy link
Contributor

@agithomas, According to the field description, the values are in nanoseconds. Should we convert it to milliseconds or seconds?

Yes, please proceed with representing time in human readable format.

@agithomas
Copy link
Contributor

@rajvi-elastic , can you please share the details what led to this steep jump?

@agithomas, Below are the 3 panels which uses conditional operations (ifelse) which is supported in 8.6 and later versions.

[Metrics MySQL] Database Overview  Minimum Kibana Version Functionality
Buffer Pool Utilization 8.6.0 Adds conditional operations in the Lens formula
Buffer Pool Efficiency 8.6.0 Adds conditional operations in the Lens formula
Network Traffic 8.6.0 Adds conditional operations in the Lens formula

@lalit-satapathy , Please note this dependency. Please let us know if there exist any concerns.

@rajvi-patel-22
Copy link
Contributor Author

Yes, please proceed with representing time in human readable format.

@agithomas, lens doesn't support human readable format for duration. However, we can normalize the value to millisecond/second using division function. But in that case there would be restrictions when value is too small. In such cases, normalized value might be near to zero and doesn't show accurate results.

@agithomas
Copy link
Contributor

@agithomas, lens doesn't support human readable format for duration. However, we can normalize the value to millisecond/second using division function.

Please consider milli-seconds, consider the usecase here of query time.
Also, please see if you can add decimals of 2 numbers to handle when duration is less than 0ms
Please add the unit (milli second) or (ms) in the column title.

@rajvi-patel-22
Copy link
Contributor Author

@agithomas, lens doesn't support human readable format for duration. However, we can normalize the value to millisecond/second using division function.

Please consider milli-seconds, consider the usecase here of query time. Also, please see if you can add decimals of 2 numbers to handle when duration is less than 0ms Please add the unit (milli second) or (ms) in the column title.

@agithomas, PR has been updated with suggested changes.

@lalit-satapathy
Copy link
Collaborator

@lalit-satapathy , the version change is a steep jump to 8.6.0 for MySQL. Are there concerns?

Need to wait for large version changes like this below, as we are discussing with others:

 - kibana.version: "^7.14.0 || ^8.0.0"
 + kibana.version: "^8.6.0"

@botelastic
Copy link

botelastic bot commented May 16, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label May 16, 2023
@botelastic
Copy link

botelastic bot commented Jun 15, 2023

Hi! This PR has been stale for a while and we're going to close it as part of our cleanup procedure. We appreciate your contribution and would like to apologize if we have not been able to review it, due to the current heavy load of the team. Feel free to re-open this PR if you think it should stay open and is worth rebasing. Thank you for your contribution!

@botelastic botelastic bot closed this Jun 15, 2023
@rajvi-patel-22 rajvi-patel-22 requested a review from a team as a code owner June 29, 2023 07:28
@botelastic botelastic bot removed the Stalled label Jun 29, 2023
@rajvi-patel-22 rajvi-patel-22 self-assigned this Jul 10, 2023
@lalit-satapathy
Copy link
Collaborator

lalit-satapathy commented Jul 17, 2023

@lalit-satapathy , the version change is a steep jump to 8.6.0 for MySQL. Are there concerns?

Need to wait for large version changes like this below, as we are discussing with others:

 - kibana.version: "^7.14.0 || ^8.0.0"
 + kibana.version: "^8.6.0"

We should go ahead with version change for Lens, as TSDB will soon migrate this package to 8.8

@lalit-satapathy
Copy link
Collaborator

FYI mysql package is already at 8.8.0 kibana version, so this can be un-gated.

@rajvi-patel-22
Copy link
Contributor Author

rajvi-patel-22 commented Jul 17, 2023

FYI mysql package is already at 8.8.0 kibana version, so this can be un-gated.

Yes @lalit-satapathy, I have updated the MySQL PRs (#5818 & #5819).

@rajvi-patel-22 rajvi-patel-22 changed the title [O11y][MySQL] Migrate [Logs MySQL] Overview dashboard visualizations to lens in kibana 8.6.0 [O11y][MySQL] Migrate [Logs MySQL] Overview dashboard visualizations to lens in kibana 8.8.0 Jul 18, 2023
Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit fff5b94 into elastic:main Jul 19, 2023
@elasticmachine
Copy link

Package mysql - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=mysql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:mysql MySQL Team:Service-Integrations Label for the Service Integrations team v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants