Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][AWS Usage] Migrate Usage Overview dashboard visualizations to lens in kibana 8.7.1 #6368

Conversation

milan-elastic
Copy link
Contributor

@milan-elastic milan-elastic commented May 30, 2023

  • Enhancement

What does this PR do?

  • Migrate visualizations to lens for Usage Overview dashboard of AWS integration package

  • Statistics for Usage Overview Lens migration:

AWS Usage Overview dashboard Before Migration   After Migration  
  Lens Visualization Lens Visualization New control Panel
[Metrics AWS] Usage Overview 0 4 4 0 3
  0 4 4 0 3

Note:

  • As per the discussion, panels with split chart functionality will be migrated to horizontal bar chart.
  • Added y-axis to line charts to provide better user experience.
  • Screenshot for dashboard is outdated currently, please refer this before migrated screenshot.

Before Migration:
screencapture-dev-4-kb-us-central1-gcp-cloud-es-io-9243-app-dashboards-2023-05-30-17_38_42

After Migration:

metricbeat-aws-usage-overview

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to lens.
  • I have updated screenshots of dashboard.
  • I have verified that data count are matching and panel aggregations are same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.7.1 itself.

Related issues

@milan-elastic milan-elastic requested review from a team as code owners May 30, 2023 12:59
@milan-elastic milan-elastic marked this pull request as draft May 30, 2023 13:04
@elasticmachine
Copy link

elasticmachine commented May 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-06T10:38:04.314+0000

  • Duration: 48 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 190
Skipped 4
Total 194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 30, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -1.25
Classes 93.75% (15/16) 👎 -1.25
Methods 85.921% (238/277) 👎 -1.93
Lines 85.925% (7387/8597) 👎 -0.381
Conditionals 100.0% (0/0) 💚

@drewdaemon
Copy link
Contributor

Great to see this happening! Two requests

legacy dashboard controls

Can we swap out those legacy dashboard controls for the new version?

When the legacy dashboard controls are removed from the layout, you can make the two donut charts on the first row take up the entire horizontal space. Feel free to experiment with changing these to Lens tree maps... I think it would probably use the space much more efficiently while accomplishing the same thing as the pie charts.

chart colors

Can we switch the color palettes for the visualizations to the system default?

Old palette:
Screenshot 2023-03-30 at 4 37 09 PM

Default palette
Screenshot 2023-03-30 at 4 37 24 PM

@milan-elastic
Copy link
Contributor Author

Great to see this happening! Two requests

legacy dashboard controls

Can we swap out those legacy dashboard controls for the new version?

When the legacy dashboard controls are removed from the layout, you can make the two donut charts on the first row take up the entire horizontal space. Feel free to experiment with changing these to Lens tree maps... I think it would probably use the space much more efficiently while accomplishing the same thing as the pie charts.

chart colors

Can we switch the color palettes for the visualizations to the system default?

Old palette: Screenshot 2023-03-30 at 4 37 09 PM

Default palette Screenshot 2023-03-30 at 4 37 24 PM

Thanks for the review @drewdaemon !

  • Regarding the new controls, we have already made the changes in this PR. You can refer to the screenshot here. Also I am updating the description in PR with the latest screenshot as well to showcase how the dashboards look like before and after migration.

  • For the color palette, we have kept the same palette (compatibility) as it was earlier. Let me know if you feel we should change the current palette to default, I'll change it.

Before Migration:

image (2)

After Migration:

image (3)

@milan-elastic milan-elastic self-assigned this May 31, 2023
@milan-elastic milan-elastic added the enhancement New feature or request label May 31, 2023
@drewdaemon
Copy link
Contributor

@milan-elastic sorry I see that this is a draft, so perhaps I was too quick on the review.

The compatibility palette was added to make it easier for customers out in the wild who convert their legacy visualizations to Lens. Since these are managed dashboards, let's go with the default palette.

@milan-elastic milan-elastic marked this pull request as ready for review June 1, 2023 12:23
Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@milan-elastic milan-elastic linked an issue Jun 1, 2023 that may be closed by this pull request
5 tasks
@milan-elastic milan-elastic merged commit f71a0c8 into elastic:main Jun 6, 2023
@elasticmachine
Copy link

Package aws - 1.40.5 containing this change is available at https://epr.elastic.co/search?package=aws

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
…lens in kibana 8.7.1 (#6368)

* Migrate Usage Overview dashboard visualizations to lenses

* Update changelog

* Address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:aws AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O11y][AWS Usage Metrics] Lens Migration
6 participants