-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O11y][AWS CloudTrail] Migrate AWS CloudTrail
dashboard visualizations to lenses in Kibana 8.7.1
#6374
[O11y][AWS CloudTrail] Migrate AWS CloudTrail
dashboard visualizations to lenses in Kibana 8.7.1
#6374
Conversation
🌐 Coverage report
|
Thanks, @harnish-elastic ! Can we change the palettes for the visualizations to "default"? |
Thanks, @drewdaemon for the review! I think the
Also, please refer the below visualization taken from the dashboard! It is showing the different hardcoded colors, that lens doesn't support! Let me know if you still strongly feel to change the color palette to |
@harnish-elastic if the visualization had custom hard-coded colors, we should probably leave it. In your success/failure example, it makes sense to use green and red. But, for the visualizations using the The |
@drewdaemon, Regarding color palette, What if TSVB visualization have configured gradient color palette? Should we configure positive, negative, warm etc. color palette or keep the default one in lens? Below is the screenshot of ELB Access Log dashboard before and after migration. In area charts, gradient color palettes have been used. When we migrated to the lens, we tried to set the closest color palette from the options. ELB Access Log dashboard before MigrationELB Access Log dashboard after MigrationLet me know what are your thoughts on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@rajvi-elastic I think you did well there. If it seems like the colors were intentionally chosen in the TSVB visualization, it probably makes sense to keep them. My only request is that if you end up with the |
@drewdaemon Understood, Thank you for the explanation! |
…into lens_migration-aws-cloudtrail Conflicts: packages/aws/changelog.yml packages/aws/manifest.yml
…into lens_migration-aws-cloudtrail Conflicts: packages/aws/changelog.yml
…into lens_migration-aws-cloudtrail Conflicts: packages/aws/changelog.yml
Package aws - 1.40.4 containing this change is available at https://epr.elastic.co/search?package=aws |
…ons to lenses in Kibana 8.7.1 (#6374) * Migrate AWS CloudTrail dashboard visualizations to lenses. * update changelog.yml * update color palette to default for all visualizations
What does this PR do?
Manually migrate AWS
CloudTrail
visualizations to the lens in the current Kibana version8.7.1
itself.Statistics for Usage Overview Lens migration:
Notes:
Donut charts
size across the dashboard and added the legend as well as show values inside and outside for better visualize and readability.CloudTrail Event Outcome over time [Logs AWS]
, in the before migrated visualization, we haveShow missing values
toggle on! Hence if the field (event.outcome
) defined for that visualization is not present, then it will show thecount of records
and also put the labels with (unknown
). Please refer the below screenshot for more information.Before migration
:Now while migrating the visualization to lens, found that if we need to implement the same functionality, we need to do
Group remaining values as "Other"
toggle on and then we can able to doinclude documents without the selected field
. Please refer the below screenshot for more information.After migration
:Now for the
Show missing values
toggle, in lens we have alternative for this functionality asinclude documents without the selected field
toggle. To enable this toggle in lens I must need to enable theGroup remaining values as "Other"
toggle. Hence I should proceed with enable the Group remaining values as "Other" toggle.Q. What happens when I enable Group remaining values as "Other" toggle?
Ans. If I enable Group remaining values as "Other" toggle, user can have the additional information in
Other
named bucket other than defined size. For example, if I have the 7 unique values for one field and I have defined my size of the breakdown as 5, I will get 2 unique value informations asOther
named bucket in the visualization.CloudTrail Event Outcome over time [Logs AWS]
chart, before migrated screenshot has hardcoded the colors over color palette to visualize thesuccess
andfailure
. However while migrating this visualization into lens, we are not able to hardcode the colors overcolor palette
.before
migrated screenshot.Checklist
changelog.yml
file.Author's Checklist
Related issues