Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][MySQL] Update system test cases #6394

Merged
merged 2 commits into from
Jun 2, 2023

Conversation

ali786XI
Copy link
Contributor

@ali786XI ali786XI commented May 31, 2023

  • Enhancement

What does this PR do?

  • This PR updates system test cases for the MySQL package.
  • System tests are done in the supported versions mentioned in the variants.yml due to this issue.
    Conversation for the same:- Link
  • Updated sample_event.json for the performance data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

How to test this PR locally

  • Clone integrations repo.
  • Install elastic-package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/mysql directory.
  • Run the following command to run the system tests. elastic-package test system

Related issues

image
image
image

@ali786XI ali786XI requested a review from a team as a code owner May 31, 2023 10:44
@cla-checker-service
Copy link

cla-checker-service bot commented May 31, 2023

💚 CLA has been signed

@ali786XI ali786XI marked this pull request as draft May 31, 2023 10:52
@elasticmachine
Copy link

elasticmachine commented May 31, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-31T13:59:50.958+0000

  • Duration: 23 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 63
Skipped 0
Total 63

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 92.857% (26/28)
Lines 93.706% (134/143)
Conditionals 100.0% (0/0) 💚

@ali786XI ali786XI self-assigned this May 31, 2023
@ali786XI ali786XI added the enhancement New feature or request label May 31, 2023
@ali786XI ali786XI force-pushed the mysql_system_test_performance branch from dbde88c to 5533124 Compare May 31, 2023 13:59
@ali786XI ali786XI marked this pull request as ready for review May 31, 2023 15:30
@ali786XI ali786XI changed the title [O11y][MySQL] Update system test cases for performance [O11y][MySQL] Update system test cases Jun 1, 2023
Copy link
Contributor

@harnish-elastic harnish-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ali786XI ali786XI merged commit 3099756 into elastic:main Jun 2, 2023
@elasticmachine
Copy link

Package mysql - 1.12.1 containing this change is available at https://epr.elastic.co/search?package=mysql

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
* Update system test

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:mysql MySQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write system test cases for performance data stream of Mysql
4 participants