Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AWS][ELB] Migrate AWS ELB Access Log dashboard visualizations to lens #6521

Merged
merged 4 commits into from
Jun 14, 2023
Merged

[AWS][ELB] Migrate AWS ELB Access Log dashboard visualizations to lens #6521

merged 4 commits into from
Jun 14, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

  • Enhancement

What does this PR do?

  • Manually migrate AWS ELB Access Log visualizations to the lens in the current Kibana version 8.7.1 itself.

  • Statistics for AWS ELB Access Log Lens migration:

Dashboad Name Control Panels Before Migration   After Migration  
    Lens Visualization Lens Visualization
[Logs AWS] ELB Access Log Overview 0 0 8 8 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.7.1 itself.

Related issues

Note:

Please refer the below Before Migrated screenshot to compare!
image

@rajvi-patel-22 rajvi-patel-22 added enhancement New feature or request Integration:aws AWS labels Jun 9, 2023
@rajvi-patel-22 rajvi-patel-22 requested review from a team as code owners June 9, 2023 06:45
@rajvi-patel-22 rajvi-patel-22 self-assigned this Jun 9, 2023
@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Jun 9, 2023
Closed
5 tasks
@elasticmachine
Copy link

elasticmachine commented Jun 9, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-14T05:18:14.309+0000

  • Duration: 55 min 58 sec

Test stats 🧪

Test Results
Failed 0
Passed 190
Skipped 4
Total 194

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 9, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -3.378
Classes 93.75% (15/16) 👎 -3.378
Methods 85.921% (238/277) 👎 -6.817
Lines 85.925% (7387/8597) 👎 -6.418
Conditionals 100.0% (0/0) 💚

drewdaemon
drewdaemon approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@drewdaemon drewdaemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

zmoog
zmoog approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @rajvi-elastic

@rajvi-patel-22 rajvi-patel-22 merged commit ba6cbb0 into elastic:main Jun 14, 2023
@elasticmachine
Copy link

Package aws - 1.44.3 containing this change is available at https://epr.elastic.co/search?package=aws

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
@rajvi-patel-22 @sodhikirti07
[AWS][ELB] Migrate AWS ELB Access Log dashboard visualizations to lens (
838d37d 
#6521)

* Migrate AWS ELB Access Log dashboard visualizations to lens

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milan-elastic milan-elastic milan-elastic approved these changes

@drewdaemon drewdaemon drewdaemon approved these changes

@zmoog zmoog zmoog approved these changes

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
enhancement New feature or request Integration:aws AWS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][AWS ELB] Lens Migration
5 participants
@rajvi-patel-22 @elasticmachine @zmoog @drewdaemon @milan-elastic