Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][AWS] Migrate AWS Billing dashboard visualizations to lens #6644

Merged
merged 9 commits into from
Jul 20, 2023
Merged

[O11y][AWS] Migrate AWS Billing dashboard visualizations to lens #6644

merged 9 commits into from
Jul 20, 2023

Conversation

rajvi-patel-22
Copy link
Contributor

@rajvi-patel-22 rajvi-patel-22 commented Jun 21, 2023 •
edited by ali786XI
Loading

  • Enhancement

What does this PR do?

  • Manually migrate AWS Billing visualizations to the lens in the current Kibana version 8.8.1 itself.

  • Statistics for AWS Billing Lens migration:

Migration stats

AWS Billing Dashboards Before Migration       After Migration      
  Maps Search Lens Visualization Maps Search Lens Visualization
[Metrics AWS] Billing Overview 0 0 0 4 0 0 4 0

Checklist

  • I have added an entry to my package's changelog.yml file.
  • I have verified that panels are populated with data.
  • I have verified that panels are not distorted after being migrated to the lens.
  • I have updated screenshots of the dashboard.
  • I have verified that the data counts are matching and panel aggregations are the same as before.

Author's Checklist

  • Migrated panels should be removed from visualization folder.
  • Migrated visualizations are populating in current Kibana version 8.7.1 itself.

Related issues

Note:

Please refer the below Before Migrated screenshot to compare!
image

@rajvi-patel-22 rajvi-patel-22 self-assigned this Jun 21, 2023
@elasticmachine
Copy link

elasticmachine commented Jun 21, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-20T19:13:31.754+0000

  • Duration: 52 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 204
Skipped 4
Total 208

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jun 21, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👍
Classes 94.444% (17/18) 👍
Methods 85.953% (257/299) 👍
Lines 86.011% (7501/8721) 👍
Conditionals 100.0% (0/0) 💚

@rajvi-patel-22 rajvi-patel-22 mentioned this pull request Jul 3, 2023
Closed
5 tasks
@rajvi-patel-22 rajvi-patel-22 marked this pull request as ready for review July 3, 2023 08:39
@rajvi-patel-22 rajvi-patel-22 requested review from a team as code owners July 3, 2023 08:39
gpop63
gpop63 reviewed Jul 3, 2023
View reviewed changes
packages/aws/kibana/dashboard/aws-e6776b10-1534-11ea-841c-01bf20a6c8ba.json
},
"title": "",
"type": "lens",
"visualizationType": "lnsLegacyMetric"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Total Estimated Charges chart maybe we should use the new Metric chart type instead of the legacy one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpop63, As discussed with the @kaiyan-sheng, if we use the new metric chart and if the value is 5004 then the new metric visualization will show us 5k. It won't show us the actual value that is 5004. Also there isn't any option available to change this behavior. Hence we need to create a legacy metric for this particular panel! Let me know if you strongly feel that this should be new metric chart!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI this is changed in kibana 8.9 (custom format is added), so it can be updated at some point in the future.

mbondyra
mbondyra reviewed Jul 5, 2023
View reviewed changes
packages/aws/kibana/dashboard/aws-e6776b10-1534-11ea-841c-01bf20a6c8ba.json
}
],
"palette": {
"name": "default",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that we use default palette which is great, but I think the screenshot above is still showing compatibility palette? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right! I will update the screenshot.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created an issue to track this: #6835

@rajvi-patel-22
Copy link
Contributor Author

/test

mbondyra
mbondyra approved these changes Jul 7, 2023
View reviewed changes
Copy link

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rajvi-patel-22 rajvi-patel-22 merged commit aff8ec4 into elastic:main Jul 20, 2023
@elasticmachine
Copy link

Package aws - 1.50.2 containing this change is available at https://epr.elastic.co/search?package=aws

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harnish-elastic harnish-elastic harnish-elastic approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@mbondyra mbondyra mbondyra approved these changes

@gpop63 gpop63 Awaiting requested review from gpop63

Assignees

@rajvi-patel-22 rajvi-patel-22

Labels
Integration:aws AWS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][AWS Billing] Lens Migration
6 participants
@rajvi-patel-22 @elasticmachine @mbondyra @kaiyan-sheng @gpop63 @harnish-elastic