Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CockroachDB] Enable TSDB #6774

Merged
merged 5 commits into from
Aug 28, 2023
Merged

Conversation

ritalwar
Copy link
Contributor

@ritalwar ritalwar commented Jul 3, 2023

  • Enhancement

What does this PR do?

This PR enables TSDB on cockroachDB package. It enables index_mode: "time_series" for all the CockroachDB metrics data streams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@ritalwar ritalwar requested a review from a team as a code owner July 3, 2023 04:33
@elasticmachine
Copy link

elasticmachine commented Jul 3, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-22T12:43:58.371+0000

  • Duration: 16 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 4
Skipped 0
Total 4

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Jul 3, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 75.0% (3/4) 👍 25.0
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚

@ritalwar ritalwar mentioned this pull request Jul 3, 2023
6 tasks
@botelastic
Copy link

botelastic bot commented Aug 2, 2023

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Aug 2, 2023
@lalit-satapathy
Copy link
Collaborator

@ritalwar, What needs to be done here?

@botelastic botelastic bot removed the Stalled label Aug 16, 2023
@ritalwar
Copy link
Contributor Author

@ritalwar, What needs to be done here?

We were waiting for the 8.9 release, and following your suggestion, for Prometheus to merge first with dynamic template changes. Now that this is done last week, I'll submit the metric_type PR again to reverse the dynamic mapping changes and can then merge this.

Copy link
Collaborator

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ritalwar ritalwar merged commit ebe6944 into elastic:main Aug 28, 2023
1 check passed
@elasticmachine
Copy link

Package cockroachdb - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=cockroachdb

@andrewkroh andrewkroh added the Integration:cockroachdb CockroachDB Metrics label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:cockroachdb CockroachDB Metrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants