-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GCP] Fix loadbalancing_metrics prefix #7287
Conversation
🌐 Coverage report
|
packages/gcp/changelog.yml
Outdated
@@ -1,4 +1,9 @@ | |||
# newer versions go on top | |||
- version: "2.24.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought : Should this be a minor version bump as there is a change in field name. cc : @andrewkroh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, this should be a minor version bump
@gpop63 What will be the impact on the users using this integration, when they upgrade? |
@ishleenk17 won't be a breaking change since fields were still using the correct prefix because of the pipeline (I'll look more into it). This is before changing
After the change:
|
Package gcp - 2.26.0 containing this change is available at https://epr.elastic.co/search?package=gcp |
What does this PR do?
Loadbalancing dashboards are using
gcp.loadbalancing
prefix but they need to usegcp.loadbalancing_metrics
since the pipeline is using this naming. The fields prefix infields.yml
is also wrong.Checklist
changelog.yml
file.Author's Checklist
How to test this PR locally
Related issues
Screenshots