Skip to content

Commit

Permalink
[Reporting] remove legacy csv export type (#121435)
Browse files Browse the repository at this point in the history
* [Reporting] remove legacy pdf shim

* remove supporting files for deprecated type

* cleanup generation URLs that are only used for usage

* remove legacy csv export type

* fix a11y test

* fix bwc test

* fix ts

* fix test snapshot

* fix test

* fix telemetry mappings

* fix a11y test

* fix unused t10s

* fix ts

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
tsullivan and kibanamachine authored Dec 21, 2021
1 parent d6fe658 commit 01d74cf
Show file tree
Hide file tree
Showing 40 changed files with 102 additions and 3,662 deletions.
33 changes: 1 addition & 32 deletions x-pack/plugins/reporting/README.md
Original file line number Diff line number Diff line change
@@ -1,34 +1,3 @@
# Kibana Reporting

An awesome Kibana reporting plugin

# Development

Assuming you've checked out x-plugins next to kibana...

- Run `yarn kbn bootstrap`
- Run `yarn start` to watch for and sync files on change
- Open a new terminal to run Kibana - use `yarn start` to launch it in dev mode
- Kibana will automatically restart as files are synced
- If you need debugging output, run `DEBUG=reporting yarn start` instead

If you have installed this somewhere other than via x-plugins, and next to the kibana repo, you'll need to change the `pathToKibana` setting in `gulpfile.js`

# Conventions

This plugins adopts some conventions in addition to or in place of conventions in Kibana (at the time of the plugin's creation):

## Folder structure
```
export_types/ (contains public and server aspects of the different export types)
printable_pdf/
public/
server/
csv/
public/
server/
public/ (shared public code for all export types)
server/ (shared server code for all export types)
```

This folder structure treats the different export_types like Plugins, with their public/server code being separate in a folder.
An awesome Kibana reporting plugin
63 changes: 0 additions & 63 deletions x-pack/plugins/reporting/common/types/export_types/csv.ts

This file was deleted.

24 changes: 0 additions & 24 deletions x-pack/plugins/reporting/server/export_types/csv/create_job.ts

This file was deleted.

Loading

0 comments on commit 01d74cf

Please sign in to comment.