Skip to content

Commit

Permalink
Minor fixup
Browse files Browse the repository at this point in the history
  • Loading branch information
madirey committed Jul 17, 2020
1 parent e5731e5 commit 08afa76
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export class Manifest {
schemaVersion: string,
oldManifest: Manifest
): Manifest {
const manifest = new Manifest(schemaVersion, oldManifest.getVersion());
const manifest = new Manifest(schemaVersion, oldManifest.getSoVersion());
artifacts.forEach((artifact) => {
const id = getArtifactId(artifact);
const existingArtifact = oldManifest.getArtifact(id);
Expand Down Expand Up @@ -129,11 +129,11 @@ export class Manifest {
return this.schemaVersion;
}

public getVersion(): string | undefined {
public getSoVersion(): string | undefined {
return this.version;
}

public setVersion(version: string) {
public setSoVersion(version: string) {
this.version = version;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ export class ManifestManager {
try {
await this.packageConfigService.update(this.savedObjectsClient, id, newPackageConfig);
this.logger.debug(
`Updated package config ${id} with manifest version ${manifest.getVersion()}`
`Updated package config ${id} with manifest version ${manifest.getSha256()}`
);
} catch (err) {
errors.push(err);
Expand Down Expand Up @@ -289,7 +289,7 @@ export class ManifestManager {

// Commit the new manifest
const manifestSo = manifest.toSavedObject();
const version = manifest.getVersion();
const version = manifest.getSoVersion();

if (version == null) {
await manifestClient.createManifest(manifestSo);
Expand Down

0 comments on commit 08afa76

Please sign in to comment.