Improves the tests

elastic · Feb 12, 2022 · 18e417a · 18e417a
1 parent 59f6f12
commit 18e417a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 19 deletions.
diff --git a/x-pack/plugins/security_solution/server/lib/detection_engine/signals/utils.test.ts b/x-pack/plugins/security_solution/server/lib/detection_engine/signals/utils.test.ts
@@ -594,34 +594,21 @@ describe('utils', () => {
       expect(exceptions).toEqual([getExceptionListItemSchemaMock()]);
     });
 
-    test('it throws if "getExceptionListClient" fails', async () => {
+    test('it throws if "findExceptionListsItemPointInTimeFinder" fails anywhere', async () => {
       const err = new Error('error fetching list');
       listMock.getExceptionListClient = () =>
         ({
-          getExceptionList: jest.fn().mockRejectedValue(err),
+          findExceptionListsItemPointInTimeFinder: jest.fn().mockRejectedValue(err),
         } as unknown as ExceptionListClient);
 
       await expect(() =>
         getExceptions({
           client: listMock.getExceptionListClient(),
           lists: getListArrayMock(),
         })
-      ).rejects.toThrowError('unable to fetch exception list items');
-    });
-
-    test('it throws if "findExceptionListsItem" fails', async () => {
-      const err = new Error('error fetching list');
-      listMock.getExceptionListClient = () =>
-        ({
-          findExceptionListsItem: jest.fn().mockRejectedValue(err),
-        } as unknown as ExceptionListClient);
-
-      await expect(() =>
-        getExceptions({
-          client: listMock.getExceptionListClient(),
-          lists: getListArrayMock(),
-        })
-      ).rejects.toThrowError('unable to fetch exception list items');
+      ).rejects.toThrowError(
+        'unable to fetch exception list items, message: "error fetching list" full error: "Error: error fetching list"'
+      );
     });
 
     test('it returns empty array if "findExceptionListsItem" returns null', async () => {

diff --git a/x-pack/plugins/security_solution/server/lib/detection_engine/signals/utils.ts b/x-pack/plugins/security_solution/server/lib/detection_engine/signals/utils.ts
@@ -292,7 +292,7 @@ export const getExceptions = async ({
       return items;
     } catch (e) {
       throw new Error(
-        `unable to fetch exception list items, message: ${e.message} full error: ${e}`
+        `unable to fetch exception list items, message: "${e.message}" full error: "${e}"`
       );
     }
   } else {