Skip to content

Commit

Permalink
Improve code
Browse files Browse the repository at this point in the history
  • Loading branch information
kertal committed Aug 16, 2021
1 parent 32e2647 commit 20ae71e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
2 changes: 1 addition & 1 deletion test/functional/apps/discover/_discover.ts
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await PageObjects.discover.clickFieldSort('_score', 'Sort Low-High');
const currentUrlWithScore = await browser.getCurrentUrl();
expect(currentUrlWithScore).to.contain('_score');
await PageObjects.discover.clickFieldListItemAdd('_score');
await PageObjects.discover.clickFieldListItemRemove('_score');
const currentUrlWithoutScore = await browser.getCurrentUrl();
expect(currentUrlWithoutScore).not.to.contain('_score');
});
Expand Down
4 changes: 1 addition & 3 deletions test/functional/page_objects/discover_page.ts
Original file line number Diff line number Diff line change
Expand Up @@ -357,9 +357,7 @@ export class DiscoverPageObject extends FtrService {
const isLegacyDefault = await this.useLegacyTable();
if (isLegacyDefault) {
await this.retry.waitFor(`field ${field} to be added to classic table`, async () => {
return await this.testSubjects.exists(`docTableRemoveHeader-${field}`, {
allowHidden: true,
});
return await this.testSubjects.exists(`docTableHeader-${field}`);
});
} else {
await this.retry.waitFor(`field ${field} to be added to new table`, async () => {
Expand Down

0 comments on commit 20ae71e

Please sign in to comment.