update test

elastic · May 3, 2022 · 2dd9b78 · 2dd9b78
1 parent 68e8dff
commit 2dd9b78
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/...ity_solution/server/lib/detection_engine/routes/rules/add_prepackaged_rules_route.test.ts b/...ity_solution/server/lib/detection_engine/routes/rules/add_prepackaged_rules_route.test.ts
@@ -101,7 +101,7 @@ describe('add_prepackaged_rules_route', () => {
       errors: [],
     });
 
-    (legacyMigrate as jest.Mock).mockResolvedValue(getRuleMock(true, getQueryRuleParams()));
+    (legacyMigrate as jest.Mock).mockResolvedValue(getRuleMock(getQueryRuleParams()));
 
     context.core.elasticsearch.client.asCurrentUser.search.mockResolvedValue(
       elasticsearchClientMock.createSuccessTransportRequestPromise(getBasicEmptySearchResponse())

diff --git a/x-pack/test/detection_engine_api_integration/security_and_spaces/tests/index.ts b/x-pack/test/detection_engine_api_integration/security_and_spaces/tests/index.ts
@@ -13,6 +13,9 @@ export default ({ loadTestFile }: FtrProviderContext): void => {
     describe('', function () {
       this.tags('ciGroup11');
 
+      // !!NOTE: For new routes that do any updates on a rule, please ensure that you are including the legacy
+      // action migration code. We are monitoring legacy action telemetry to clean up once we see their
+      // existence being near 0.
       loadTestFile(require.resolve('./aliases'));
       loadTestFile(require.resolve('./add_actions'));
       loadTestFile(require.resolve('./update_actions'));

diff --git a/...onal/es_archives/legacy_actions/data.json → ...ecurity_solution/legacy_actions/data.json b/...onal/es_archives/legacy_actions/data.json → ...ecurity_solution/legacy_actions/data.json