Skip to content

Commit

Permalink
add comment to explain why we removed the private
Browse files Browse the repository at this point in the history
  • Loading branch information
XavierM committed Oct 2, 2019
1 parent 3589d3c commit 2f2e266
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion src/plugins/data/common/field_formats/field_format.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export abstract class FieldFormat {
* @property {FieldFormatConvert}
* @private
* have to remove the private because of
* https://github.com/Microsoft/TypeScript/issues/17293\
* https://github.com/Microsoft/TypeScript/issues/17293
*/
convertObject: FieldFormatConvert | undefined;

Expand Down Expand Up @@ -173,6 +173,10 @@ export abstract class FieldFormat {
return createCustomFieldFormat(convertFn);
}

/*
* have to remove the private because of
* https://github.com/Microsoft/TypeScript/issues/17293
*/
static setupContentType(
fieldFormat: IFieldFormat,
convert: Partial<FieldFormatConvert> | FieldFormatConvertFunction = {}
Expand All @@ -187,6 +191,10 @@ export abstract class FieldFormat {
};
}

/*
* have to remove the private because of
* https://github.com/Microsoft/TypeScript/issues/17293
*/
static toConvertObject(convert: FieldFormatConvertFunction): Partial<FieldFormatConvert> {
if (isFieldFormatConvertFn(convert)) {
return {
Expand Down

0 comments on commit 2f2e266

Please sign in to comment.