Skip to content

Commit

Permalink
Better explanation about the Prettier recommendation (extension vs. N…
Browse files Browse the repository at this point in the history
…PM module) (#50629)

* Better explanation about the Prettier recommendation (extension vs. NPM module)

* Contributing docs: Add side effect from using the Prettier extension
  • Loading branch information
afharo authored Nov 18, 2019
1 parent c739e2f commit 3026912
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ Note that for VSCode, to enable "live" linting of TypeScript (and other) file ty
"eslint.autoFixOnSave": true,
```

It is **not** recommended to use `prettier` plugin on Kibana project. Because settings are in `eslintrc.js` file and it is applied to too many files that shouldn't be prettier-ized.
:warning: It is **not** recommended to use the [`Prettier` extension/IDE plugin](https://prettier.io/) while maintaining the Kibana project. Formatting and styling roles are set in the multiple `.eslintrc.js` files across the project and some of them use the [NPM version of Prettier](https://www.npmjs.com/package/prettier). Using the IDE extension might cause conflicts, applying the formatting to too many files that shouldn't be prettier-ized and/or highlighting errors that are actually OK.

### Internationalization

Expand Down

0 comments on commit 3026912

Please sign in to comment.