Skip to content

Commit

Permalink
[Synthetics] Unskip Uptime overview page functional tests (#163985)
Browse files Browse the repository at this point in the history
## Summary

Updates and unskips the overview page tests.

Resolves #89072.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Shahzad <shahzad31comp@gmail.com>
  • Loading branch information
3 people authored Aug 16, 2023
1 parent f4b925c commit 3075883
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
5 changes: 2 additions & 3 deletions x-pack/test/functional/apps/uptime/overview.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

const testSubjects = getService('testSubjects');

// FLAKY: https://github.com/elastic/kibana/issues/89072
describe.skip('overview page', function () {
describe('overview page', function () {
const DEFAULT_DATE_START = 'Sep 10, 2019 @ 12:40:08.078';
const DEFAULT_DATE_END = 'Sep 11, 2019 @ 19:40:08.078';

Expand Down Expand Up @@ -199,7 +198,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

it('can change query syntax to kql', async () => {
await testSubjects.click('switchQueryLanguageButton');
await testSubjects.click('languageToggle');
await testSubjects.click('kqlLanguageMenuItem');
});

it('runs filter query without issues', async () => {
Expand Down
6 changes: 3 additions & 3 deletions x-pack/test/functional/services/uptime/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export function UptimeCommonProvider({ getService, getPageObjects }: FtrProvider
await this.setKueryBarText('queryInput', filterQuery);
},
async goToNextPage() {
await testSubjects.click('xpack.synthetics.monitorList.nextButton', 5000);
await testSubjects.click('xpack.uptime.monitorList.nextButton', 5000);
},
async goToPreviousPage() {
await testSubjects.click('xpack.synthetics.monitorList.prevButton', 5000);
Expand Down Expand Up @@ -97,11 +97,11 @@ export function UptimeCommonProvider({ getService, getPageObjects }: FtrProvider
};
},
async openPageSizeSelectPopover(): Promise<void> {
return testSubjects.click('xpack.synthetics.monitorList.pageSizeSelect.popoverOpen', 5000);
return testSubjects.click('xpack.uptime.monitorList.pageSizeSelect.popoverOpen', 5000);
},
async clickPageSizeSelectPopoverItem(size: number = 10): Promise<void> {
return testSubjects.click(
`xpack.synthetics.monitorList.pageSizeSelect.sizeSelectItem${size.toString()}`,
`xpack.uptime.monitorList.pageSizeSelect.sizeSelectItem${size.toString()}`,
5000
);
},
Expand Down

0 comments on commit 3075883

Please sign in to comment.