[ML] Adds a check if query is a match_all query.

elastic · Apr 1, 2020 · 3664138 · 3664138
1 parent 05b60ae
commit 3664138
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 19 deletions.
diff --git a/x-pack/plugins/transform/public/app/common/request.ts b/x-pack/plugins/transform/public/app/common/request.ts
@@ -81,7 +81,7 @@ export function getPreviewRequestBody(
     },
   };
 
-  if (!isDefaultQuery(query)) {
+  if (!isDefaultQuery(query) && !isMatchAllQuery(query)) {
     request.source.query = query;
   }
 

diff --git a/...sform/public/app/sections/create_transform/components/step_define/step_define_summary.tsx b/...sform/public/app/sections/create_transform/components/step_define/step_define_summary.tsx
@@ -17,7 +17,7 @@ import {
   EuiText,
 } from '@elastic/eui';
 
-import { getPivotQuery, isDefaultQuery } from '../../../../common';
+import { getPivotQuery, isDefaultQuery, isMatchAllQuery } from '../../../../common';
 import { PivotPreview } from '../../../../components/pivot_preview';
 import { SearchItems } from '../../../../hooks/use_search_items';
 
@@ -60,24 +60,29 @@ export const StepDefineSummary: FC<Props> = ({
                     <span>{searchString}</span>
                   </EuiFormRow>
                 )}
-                {typeof searchString === 'undefined' && !isDefaultQuery(pivotQuery) && (
-                  <EuiFormRow
-                    label={i18n.translate('xpack.transform.stepDefineSummary.queryCodeBlockLabel', {
-                      defaultMessage: 'Query',
-                    })}
-                  >
-                    <EuiCodeBlock
-                      language="js"
-                      fontSize="s"
-                      paddingSize="s"
-                      color="light"
-                      overflowHeight={300}
-                      isCopyable
+                {typeof searchString === 'undefined' &&
+                  !isDefaultQuery(pivotQuery) &&
+                  !isMatchAllQuery(pivotQuery) && (
+                    <EuiFormRow
+                      label={i18n.translate(
+                        'xpack.transform.stepDefineSummary.queryCodeBlockLabel',
+                        {
+                          defaultMessage: 'Query',
+                        }
+                      )}
                     >
-                      {JSON.stringify(pivotQuery, null, 2)}
-                    </EuiCodeBlock>
-                  </EuiFormRow>
-                )}
+                      <EuiCodeBlock
+                        language="js"
+                        fontSize="s"
+                        paddingSize="s"
+                        color="light"
+                        overflowHeight={300}
+                        isCopyable
+                      >
+                        {JSON.stringify(pivotQuery, null, 2)}
+                      </EuiCodeBlock>
+                    </EuiFormRow>
+                  )}
               </Fragment>
             )}
-Original file line number
+Diff line change
@@ Expand Up / @@ -81,7 +81,7 @@ export function getPreviewRequestBody( @@
         },
       };
-      if (!isDefaultQuery(query)) {
+      if (!isDefaultQuery(query) && !isMatchAllQuery(query)) {
         request.source.query = query;
       }
@@ Expand Down @@