Skip to content

Commit

Permalink
[kbn-securitysolution-exception-list-components] Require pageSize a…
Browse files Browse the repository at this point in the history
…nd DRY out types
  • Loading branch information
cee-chen committed Aug 15, 2023
1 parent abcf499 commit 36e9772
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,14 @@ import { css } from '@emotion/react';
import type { FC } from 'react';
import { EuiCommentProps, EuiFlexGroup, EuiFlexItem } from '@elastic/eui';

import type { Pagination as PaginationType } from '@elastic/eui';

import type {
CommentsArray,
ExceptionListItemSchema,
ExceptionListTypeEnum,
} from '@kbn/securitysolution-io-ts-list-types';

import { euiThemeVars } from '@kbn/ui-theme';
import { EmptyViewerState, ExceptionItemCard, Pagination } from '../..';
import { EmptyViewerState, ExceptionItemCard, Pagination, PaginationProps } from '../..';

import type {
RuleReferences,
Expand All @@ -46,7 +44,7 @@ interface ExceptionItemsProps {
exceptions: ExceptionListItemSchema[];
listType: ExceptionListTypeEnum;
ruleReferences: RuleReferences;
pagination: PaginationType;
pagination: PaginationProps['pagination'];
editActionLabel?: string;
deleteActionLabel?: string;
dataTestSubj?: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@ import type { Pagination } from '@elastic/eui';
import type { NamespaceType } from '@kbn/securitysolution-io-ts-list-types';

export interface GetExceptionItemProps {
pagination?: Pagination;
pagination?: PaginationProps['pagination'];
search?: string;
filters?: string;
}

export interface PaginationProps {
dataTestSubj?: string;
ariaLabel?: string;
pagination: Pagination;
pagination: Pagination & { pageSize: number };
onPaginationChange: (arg: GetExceptionItemProps) => void;
}

Expand Down

0 comments on commit 36e9772

Please sign in to comment.