PR feedback: Remove useRef/on mount onChange catch for now

- We don't currently need the extra catch for any live components, and it's confusing
elastic · Apr 14, 2021 · 3931eb3 · 3931eb3
1 parent 5d97f84
commit 3931eb3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/...arch/public/applications/app_search/components/multi_input_rows/multi_input_rows.test.tsx b/...arch/public/applications/app_search/components/multi_input_rows/multi_input_rows.test.tsx
@@ -129,12 +129,5 @@ describe('MultiInputRows', () => {
 
       expect(onChange).toHaveBeenCalledWith(['updated']);
     });
-
-    it('does not submit on initial render/mount (due to useRef)', () => {
-      setMockValues({ ...values, values: ['initial value'] });
-      shallow(<MultiInputRows {...props} onChange={onChange} />);
-
-      expect(onChange).not.toHaveBeenCalled();
-    });
   });
 });
diff --git a/...se_search/public/applications/app_search/components/multi_input_rows/multi_input_rows.tsx b/...se_search/public/applications/app_search/components/multi_input_rows/multi_input_rows.tsx
@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-import React, { useEffect, useRef } from 'react';
+import React, { useEffect } from 'react';
 
 import { useValues, useActions } from 'kea';
 
@@ -47,12 +47,10 @@ export const MultiInputRows: React.FC<Props> = ({
   const { values, hasEmptyValues, hasOnlyOneValue } = useValues(logic);
   const { addValue, editValue, deleteValue } = useActions(logic);
 
-  const hasChanged = useRef(false);
   useEffect(() => {
-    if (onChange && hasChanged.current) {
+    if (onChange) {
       onChange(filterEmptyValues(values));
     }
-    hasChanged.current = true;
   }, [values]);
 
   return (