Skip to content

Commit

Permalink
Move buttons and make active the default
Browse files Browse the repository at this point in the history
  • Loading branch information
smith committed May 25, 2021
1 parent ba2e5ae commit 3b17d0d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion x-pack/plugins/observability/public/pages/alerts/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export function AlertsPage({ routeParams }: AlertsPageProps) {
const { prepend } = core.http.basePath;
const history = useHistory();
const {
query: { rangeFrom = 'now-15m', rangeTo = 'now', kuery = '', status = 'all' },
query: { rangeFrom = 'now-15m', rangeTo = 'now', kuery = '', status = 'active' },
} = routeParams;

// In a future milestone we'll have a page dedicated to rule management in
Expand Down
20 changes: 10 additions & 10 deletions x-pack/plugins/observability/public/pages/alerts/status_filter.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,6 @@ export interface StatusFilterProps {
export function StatusFilter({ status = 'open', onChange }: StatusFilterProps) {
return (
<EuiFilterGroup>
<EuiFilterButton
data-test-subj="StatusFilter all button"
hasActiveFilters={status === 'all'}
onClick={() => onChange('all')}
withNext={true}
>
{i18n.translate('xpack.observability.alerts.statusFilter.allButtonLabel', {
defaultMessage: 'All',
})}
</EuiFilterButton>
<EuiFilterButton
data-test-subj="StatusFilter open button"
hasActiveFilters={status === 'open'}
Expand All @@ -42,11 +32,21 @@ export function StatusFilter({ status = 'open', onChange }: StatusFilterProps) {
data-test-subj="StatusFilter closed button"
hasActiveFilters={status === 'closed'}
onClick={() => onChange('closed')}
withNext={true}
>
{i18n.translate('xpack.observability.alerts.statusFilter.recoveredButtonLabel', {
defaultMessage: 'Recovered',
})}
</EuiFilterButton>
<EuiFilterButton
data-test-subj="StatusFilter all button"
hasActiveFilters={status === 'all'}
onClick={() => onChange('all')}
>
{i18n.translate('xpack.observability.alerts.statusFilter.allButtonLabel', {
defaultMessage: 'All',
})}
</EuiFilterButton>
</EuiFilterGroup>
);
}

0 comments on commit 3b17d0d

Please sign in to comment.