Fixing logic for connectors with optional secrets

elastic · May 5, 2021 · 3be3824 · 3be3824
1 parent 6d3d7ee
commit 3be3824
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/x-pack/plugins/actions/server/saved_objects/transform_connectors_for_export.ts b/x-pack/plugins/actions/server/saved_objects/transform_connectors_for_export.ts
@@ -32,9 +32,9 @@ function transformConnectorForExport(
     // If connector requires secrets, this will throw an error
     validateSecrets(actionType, {});
 
-    // If connector has optional secrets, set isMissingSecrets value to value of hasAuth
-    // If connector doesn't have hasAuth value, default to isMissingSecrets: true
-    isMissingSecrets = (connector?.attributes?.config?.hasAuth as boolean) ?? true;
+    // If connector has optional (or no) secrets, set isMissingSecrets value to value of hasAuth
+    // If connector doesn't have hasAuth value, default to isMissingSecrets: false
+    isMissingSecrets = (connector?.attributes?.config?.hasAuth as boolean) ?? false;
   } catch (err) {
     isMissingSecrets = true;
   }