Switch to ruleMap.get() for less typescript errors

elastic · Apr 12, 2021 · 3df98ad · 3df98ad
1 parent 1e56114
commit 3df98ad
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/x-pack/plugins/security_solution/server/lib/detection_engine/rules/get_prepackaged_rules.ts b/x-pack/plugins/security_solution/server/lib/detection_engine/rules/get_prepackaged_rules.ts
@@ -83,10 +83,10 @@ export const getLatestPrepackagedRules = async (
 
   // check the rules installed via fleet and create/update if the version is newer
   const fleetRules = await getFleetInstalledRules(client);
-  const fleetUpdates = fleetRules.filter(
-    // @ts-expect-error data ruleMap.get() is safe because of ruleMap.has() check
-    (r) => !ruleMap.has(r.rule_id) || ruleMap.get(r.rule_id).version < r.version
-  );
+  const fleetUpdates = fleetRules.filter((r) => {
+    const rule = ruleMap.get(r.rule_id);
+    return rule == null || rule.version < r.version;
+  });
 
   // add the new or updated rules to the map
   fleetUpdates.forEach((r) => ruleMap.set(r.rule_id, r));