Skip to content

Commit

Permalink
- Scaling down deprecation issue panel title size to flow with typogr…
Browse files Browse the repository at this point in the history
…aphic hierarchy.

- Removing panel around deprecation logging switch to reduce visual elements.
- Using success instead of green color for migration complete message.
  • Loading branch information
dborodyansky committed Oct 15, 2021
1 parent b25dd4e commit 64e0f75
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,10 @@ export const DeprecationIssuesPanel = (props: Props) => {
className="upgDeprecationIssuesPanel"
layout="horizontal"
title={deprecationSource}
titleSize="xs"
{...(!hasNoIssues && reactRouterNavigate(history, linkUrl))}
>
<EuiSpacer />
<EuiSpacer size="s"/>

{hasError ? (
<LoadingIssuesError>{errorMessage}</LoadingIssuesError>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ const i18nTexts = {
identifyStepTitle: i18n.translate('xpack.upgradeAssistant.overview.identifyStepTitle', {
defaultMessage: 'Identify deprecated API use and update your applications',
}),
toggleTitle: i18n.translate('xpack.upgradeAssistant.overview.toggleTitle', {
defaultMessage: 'Log Elasticsearch deprecation issues',
}),
analyzeTitle: i18n.translate('xpack.upgradeAssistant.overview.analyzeTitle', {
defaultMessage: 'Analyze deprecation logs',
}),
Expand Down Expand Up @@ -140,21 +137,15 @@ const FixLogsStep: FunctionComponent<Props> = ({

return (
<>
<EuiText>
<h4>{i18nTexts.toggleTitle}</h4>
</EuiText>
<EuiSpacer size="m" />
<EuiPanel>
<DeprecationLoggingToggle
isDeprecationLogIndexingEnabled={isDeprecationLogIndexingEnabled}
isLoading={isLoading}
isUpdating={isUpdating}
fetchError={fetchError}
updateError={updateError}
resendRequest={resendRequest}
toggleLogging={toggleLogging}
/>
</EuiPanel>
<DeprecationLoggingToggle
isDeprecationLogIndexingEnabled={isDeprecationLogIndexingEnabled}
isLoading={isLoading}
isUpdating={isUpdating}
fetchError={fetchError}
updateError={updateError}
resendRequest={resendRequest}
toggleLogging={toggleLogging}
/>

{onlyDeprecationLogWritingEnabled && (
<>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ const MigrateSystemIndicesStep: FunctionComponent<Props> = ({ setIsComplete }) =
<EuiIcon type="check" color="success" />
</EuiFlexItem>
<EuiFlexItem grow={false}>
<EuiText color="green">
<EuiText color="success">
<p>{i18nTexts.noMigrationNeeded}</p>
</EuiText>
</EuiFlexItem>
Expand Down

0 comments on commit 64e0f75

Please sign in to comment.