Skip to content

Commit

Permalink
fix threshold alert suppression duration type value
Browse files Browse the repository at this point in the history
  • Loading branch information
maximpn committed Nov 4, 2024
1 parent e947a7a commit 68f8fe6
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import React from 'react';
import { EuiPanel, EuiToolTip } from '@elastic/eui';
import { CheckBoxField } from '@kbn/es-ui-shared-plugin/static/forms/components';
import { UseField, useFormData } from '../../../../shared_imports';
import { SuppressionDurationSelector } from './suppression_duration_selector';
import { ThresholdSuppressionDurationSelector } from './threshold_suppression_duration_selector';
import { THRESHOLD_ALERT_SUPPRESSION_ENABLED } from './fields';
import * as i18n from './translations';

Expand Down Expand Up @@ -44,7 +44,7 @@ export function ThresholdAlertSuppressionEdit({
}}
/>
<EuiPanel paddingSize="m" hasShadow={false}>
<SuppressionDurationSelector disabled={!suppressionEnabled || disabled} />
<ThresholdSuppressionDurationSelector disabled={!suppressionEnabled || disabled} />
</EuiPanel>
</>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import { AlertSuppressionDurationType } from '../../../../detections/pages/detec
import { DurationInput } from '../duration_input';
import {
ALERT_SUPPRESSION_DURATION,
ALERT_SUPPRESSION_DURATION_TYPE,
ALERT_SUPPRESSION_DURATION_UNIT,
ALERT_SUPPRESSION_DURATION_VALUE,
} from './fields';
Expand All @@ -22,16 +23,21 @@ interface AlertSuppressionDurationProps {
disabled?: boolean;
}

export function SuppressionDurationSelector({
export function ThresholdSuppressionDurationSelector({
disabled,
}: AlertSuppressionDurationProps): JSX.Element {
return (
<EuiFormRow data-test-subj="alertSuppressionDuration">
<UseMultiFields<{
suppressionDurationType: string;
suppressionDurationValue: number | undefined;
suppressionDurationUnit: string;
}>
fields={{
suppressionDurationType: {
path: ALERT_SUPPRESSION_DURATION_TYPE,
defaultValue: AlertSuppressionDurationType.PerTimePeriod,
},
suppressionDurationValue: {
path: `${ALERT_SUPPRESSION_DURATION}.${ALERT_SUPPRESSION_DURATION_VALUE}`,
},
Expand Down

0 comments on commit 68f8fe6

Please sign in to comment.